jenkins-bot has submitted this change and it was merged.
Change subject: Prevent predefined object methods to be interpreted as valid
language
......................................................................
Prevent predefined object methods to be interpreted as valid language
Change-Id: I97bb0f8eef6a9361118527cecb4680aeac51b7e1
---
M resources/js/ext.uls.init.js
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.uls.init.js b/resources/js/ext.uls.init.js
index 47008a2..5a112e7 100644
--- a/resources/js/ext.uls.init.js
+++ b/resources/js/ext.uls.init.js
@@ -19,6 +19,8 @@
( function ( $, mw ) {
'use strict';
+ var hasOwn = Object.prototype.hasOwnProperty;
+
mw.uls = mw.uls || {};
mw.uls.previousLanguagesCookie = 'uls-previous-languages';
mw.uls.previousLanguageAutonymCookie = 'uls-previous-language-autonym';
@@ -163,7 +165,7 @@
var target;
// If the language is already known and defined, just
use it
- if ( $.fn.uls.defaults.languages[ langCode ] !==
undefined ) {
+ if ( hasOwn.call( $.fn.uls.defaults.languages, langCode
) ) {
return true;
}
@@ -174,7 +176,7 @@
if ( target ) {
// Check that the redirect's target is known
// to this instance of ULS
- return $.fn.uls.defaults.languages[ target ]
!== undefined;
+ return hasOwn.call(
$.fn.uls.defaults.languages, target );
}
return false;
--
To view, visit https://gerrit.wikimedia.org/r/112863
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97bb0f8eef6a9361118527cecb4680aeac51b7e1
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Fomafix
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
