Christopher Johnson (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190659
Change subject: fix for undefined index in setTaskPrioritySum
......................................................................
fix for undefined index in setTaskPrioritySum
Change-Id: I6734128968ca6366ad38f31beaf27e591c48c319
---
M rsrc/behavior-priority-pie.js
M src/util/SprintPoints.php
2 files changed, 13 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/phabricator/extensions/Sprint
refs/changes/59/190659/1
diff --git a/rsrc/behavior-priority-pie.js b/rsrc/behavior-priority-pie.js
index ba49e66..a7264c0 100644
--- a/rsrc/behavior-priority-pie.js
+++ b/rsrc/behavior-priority-pie.js
@@ -23,4 +23,3 @@
}
});
});
-
diff --git a/src/util/SprintPoints.php b/src/util/SprintPoints.php
index 20b2041..6c4f8f2 100644
--- a/src/util/SprintPoints.php
+++ b/src/util/SprintPoints.php
@@ -6,7 +6,7 @@
private $task_open_status_sum;
private $task_closed_status_sum;
private $tasks;
-private $taskPrioritySum;
+private $taskPrioritySum = array();
public function setTaskPoints ($taskpoints) {
$this->taskpoints = $taskpoints;
@@ -85,16 +85,24 @@
$priority_name = $this->getPriorityName($task);
$points = $this->getTaskPoints($task->getPHID());
if ($priority_name) {
- $this->taskPrioritySum =
- $this->setTaskPrioritySum($this->taskPrioritySum, $priority_name,
- $points);
+ $this->taskPrioritySum =
$this->setTaskPrioritySum($this->taskPrioritySum,
+ $priority_name,
+ $points);
}
return;
}
private function setTaskPrioritySum ($task_priority_sum, $priority_name,
$points) {
- $task_priority_sum[$priority_name] += $points;
+ if (empty($task_priority_sum)) {
+ $task_priority_sum[$priority_name] = $points;
+ } else {
+ if (isset($task_priority_sum[$priority_name])) {
+ $task_priority_sum[$priority_name] += $points;
+ } else {
+ $task_priority_sum[$priority_name] = $points;
+ }
+ }
return $task_priority_sum;
}
--
To view, visit https://gerrit.wikimedia.org/r/190659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6734128968ca6366ad38f31beaf27e591c48c319
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
