Christopher Johnson (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190661
Change subject: adds check for undefined indices in initTaskPriorityPie
......................................................................
adds check for undefined indices in initTaskPriorityPie
Change-Id: I7ce0aeb9f8258e2b7310fd7d37da524a8dc25d0b
---
M src/view/burndown/BoardDataPieView.php
1 file changed, 12 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/phabricator/extensions/Sprint
refs/changes/61/190661/1
diff --git a/src/view/burndown/BoardDataPieView.php
b/src/view/burndown/BoardDataPieView.php
index 35c649a..4f010a9 100644
--- a/src/view/burndown/BoardDataPieView.php
+++ b/src/view/burndown/BoardDataPieView.php
@@ -116,12 +116,18 @@
$id = 'priority-pie';
Javelin::initBehavior('priority-pie', array(
'hardpoint' => $id,
- 'Wishlist' => $task_priority_sum['Wishlist'],
- 'Normal' => $task_priority_sum['Normal'],
- 'High' => $task_priority_sum['High'],
- 'Unbreak' => $task_priority_sum['Unbreak Now!'],
- 'Triage' => $task_priority_sum['Needs Triage'],
- 'Low' => $task_priority_sum['Low'],
+ 'Wishlist' => (isset($task_priority_sum['Wishlist'])) ?
+ $task_priority_sum['Wishlist'] : null,
+ 'Normal' => (isset($task_priority_sum['Normal'])) ?
+ $task_priority_sum['Normal']: null,
+ 'High' => (isset($task_priority_sum['High'])) ?
+ $task_priority_sum['High']: null,
+ 'Unbreak' => (isset($task_priority_sum['Unbreak Now!'])) ?
+ $task_priority_sum['Unbreak Now!']: null,
+ 'Triage' => (isset($task_priority_sum['Needs Triage'])) ?
+ $task_priority_sum['Needs Triage']: null,
+ 'Low' => (isset($task_priority_sum['Low'])) ?
+ $task_priority_sum['Low']: null,
), 'sprint');
}
}
--
To view, visit https://gerrit.wikimedia.org/r/190661
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ce0aeb9f8258e2b7310fd7d37da524a8dc25d0b
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
