Matanya has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190668
Change subject: fix 5 string containing only a variable
......................................................................
fix 5 string containing only a variable
Change-Id: I96ccece2408eb60ddc3d9a22b8c4fb99e2a37949
---
M modules/labs_vmbuilder/manifests/init.pp
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/68/190668/1
diff --git a/modules/labs_vmbuilder/manifests/init.pp
b/modules/labs_vmbuilder/manifests/init.pp
index 556fffe..d656945 100644
--- a/modules/labs_vmbuilder/manifests/init.pp
+++ b/modules/labs_vmbuilder/manifests/init.pp
@@ -29,7 +29,7 @@
require => Package['python-vm-builder'],
}
- file { "${vmbuilder_filepath}":
+ file { $vmbuilder_filepath:
ensure => directory,
mode => '0555',
}
@@ -38,7 +38,7 @@
mode => '0555',
source => 'puppet:///modules/labs_vmbuilder/install_sudo.sh',
require => [Package['python-vm-builder'],
- File["${vmbuilder_filepath}"],
+ File[$vmbuilder_filepath],
],
}
@@ -46,16 +46,16 @@
mode => '0555',
source => 'puppet:///modules/labs_vmbuilder/vmbuilder.partition',
require => [Package['python-vm-builder'],
- File["${vmbuilder_filepath}"],
+ File[$vmbuilder_filepath],
],
}
file { 'vmbuilder_version':
path => '/etc/vmbuilder/files/vmbuilder_version',
mode => '0444',
- content => "${vmbuilder_version}",
+ content => $vmbuilder_version,
require => [Package['python-vm-builder'],
- File["${vmbuilder_filepath}"],
+ File[$vmbuilder_filepath],
],
}
--
To view, visit https://gerrit.wikimedia.org/r/190668
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96ccece2408eb60ddc3d9a22b8c4fb99e2a37949
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Matanya <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
