jenkins-bot has submitted this change and it was merged.
Change subject: test: Make code pass jscs 1.5.0 with Wikimedia code style preset
......................................................................
test: Make code pass jscs 1.5.0 with Wikimedia code style preset
Change-Id: I385f7d9ca9f641b3ad936605af1f9894a57192e5
---
A .jscsrc
M collapsibleTabs.js
M vector.js
3 files changed, 7 insertions(+), 4 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.jscsrc b/.jscsrc
new file mode 100644
index 0000000..9d22e3f
--- /dev/null
+++ b/.jscsrc
@@ -0,0 +1,3 @@
+{
+ "preset": "wikimedia"
+}
diff --git a/collapsibleTabs.js b/collapsibleTabs.js
index e24bea9..6fd8c49 100644
--- a/collapsibleTabs.js
+++ b/collapsibleTabs.js
@@ -95,7 +95,7 @@
if ( $( data.collapsedContainer + ' ' +
data.collapsible ).length > 0 &&
data.expandCondition(
$.collapsibleTabs.getSettings( $( data.collapsedContainer ).children(
data.collapsible + ':first' ) ).expandedWidth ) ) {
- //move the element from the dropdown to
the tab
+ // move the element from the dropdown
to the tab
$el.trigger( 'beforeTabExpand' );
$.collapsibleTabs
.moveToExpanded(
data.collapsedContainer + ' ' + data.collapsible + ':first' );
diff --git a/vector.js b/vector.js
index 7be3535..dafe94f 100644
--- a/vector.js
+++ b/vector.js
@@ -54,16 +54,16 @@
$cactions
.removeClass( 'emptyPortlet' )
.find( 'h3' )
- .css( 'width', '1px' ).animate(
{ 'width': originalDropdownWidth }, 'normal' );
+ .css( 'width', '1px' ).animate(
{ width: originalDropdownWidth }, 'normal' );
}
} )
.bind( 'beforeTabExpand', function () {
// If we're removing the last child node right now,
hide the dropdown
if ( $cactions.find( 'li' ).length === 1 ) {
- $cactions.find( 'h3' ).animate( { 'width':
'1px' }, 'normal', function () {
+ $cactions.find( 'h3' ).animate( { width: '1px'
}, 'normal', function () {
$( this ).attr( 'style', '' )
.parent().addClass(
'emptyPortlet' );
- });
+ } );
}
} )
.collapsibleTabs( {
--
To view, visit https://gerrit.wikimedia.org/r/190676
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I385f7d9ca9f641b3ad936605af1f9894a57192e5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Edokter <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
