Wctaiwan has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190742
Change subject: Make jquery.confirmable not clone title text
......................................................................
Make jquery.confirmable not clone title text
Don't clone the title text, if exists, from the original link when
generating the yes / no buttons since it wouldn't make sense on the
latter and is unnecessary for the former.
Bug: T89572
Change-Id: I7e1e5c6ee78aa54a97205d6682f9520008cc11dd
---
M resources/src/jquery/jquery.confirmable.js
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/42/190742/1
diff --git a/resources/src/jquery/jquery.confirmable.js
b/resources/src/jquery/jquery.confirmable.js
index 339e65a..9effb22 100644
--- a/resources/src/jquery/jquery.confirmable.js
+++ b/resources/src/jquery/jquery.confirmable.js
@@ -83,7 +83,8 @@
interfaceWidth = $interface.data(
'jquery-confirmable-width' );
elementWidth = $element.data(
'jquery-confirmable-width' );
} else {
- $elementClone = $element.clone( true );
+ // Clone the link element with the title text
removed
+ $elementClone = $element.clone( true
).removeAttr( 'title' );
$element.addClass( 'jquery-confirmable-element'
);
elementWidth = $element.width();
--
To view, visit https://gerrit.wikimedia.org/r/190742
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e1e5c6ee78aa54a97205d6682f9520008cc11dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Wctaiwan <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
