Alexandros Kosiaris has submitted this change and it was merged.
Change subject: interface: fix optional parameter listed before required
parameter
......................................................................
interface: fix optional parameter listed before required parameter
Change-Id: I41dedb4210c58ceb3239e042710fa2b9568d63b6
---
M modules/interface/manifests/offload.pp
M modules/interface/manifests/ring.pp
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alexandros Kosiaris: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/interface/manifests/offload.pp
b/modules/interface/manifests/offload.pp
index 8976bec..fb93cc3 100644
--- a/modules/interface/manifests/offload.pp
+++ b/modules/interface/manifests/offload.pp
@@ -9,7 +9,7 @@
# The (abbreviated) offload setting, e.g. 'gro'
# - $value:
# The value (on/off)
-define interface::offload($interface='eth0', $setting, $value) {
+define interface::offload($setting, $value, $interface='eth0') {
# Set in /etc/network/interfaces
interface::setting { $title: interface => $interface, setting =>
"offload-${setting}", value => $value }
diff --git a/modules/interface/manifests/ring.pp
b/modules/interface/manifests/ring.pp
index 74417cc..469c731 100644
--- a/modules/interface/manifests/ring.pp
+++ b/modules/interface/manifests/ring.pp
@@ -12,7 +12,7 @@
#
# Note this doesn't check/set at runtime, because at least with
# some drivers that restarts the interface and causes some traffic loss
-define interface::ring($interface='eth0', $setting, $value) {
+define interface::ring($setting, $value, $interface='eth0') {
# Set in /etc/network/interfaces
interface::setting { $title: interface => $interface, setting =>
"hardware-dma-ring-${setting}", value => $value }
--
To view, visit https://gerrit.wikimedia.org/r/190669
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41dedb4210c58ceb3239e042710fa2b9568d63b6
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Matanya <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
