Gilles has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190811
Change subject: Workaround for Safari web driver
......................................................................
Workaround for Safari web driver
It doesn't support mouse move, so let's do a plain click in that case
Bug: T89087
Change-Id: Idb89b72896d29772aff893c7cde92728450cc678
---
M tests/browser/features/step_definitions/mmv_steps.rb
1 file changed, 6 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer
refs/changes/11/190811/1
diff --git a/tests/browser/features/step_definitions/mmv_steps.rb
b/tests/browser/features/step_definitions/mmv_steps.rb
index 3011abb..6a30a8f 100644
--- a/tests/browser/features/step_definitions/mmv_steps.rb
+++ b/tests/browser/features/step_definitions/mmv_steps.rb
@@ -43,7 +43,12 @@
on(E2ETestPage) do |page|
# Clicking the top-left corner of the image is necessary for the test to
work on IE
# A plain click on the image element ends up hitting the dialog, which
means it won't close
- @browser.driver.action.move_to(@browser.driver.find_element(:class,
'mw-mmv-image'), 10, 10).click.perform
+ begin
+ @browser.driver.action.move_to(@browser.driver.find_element(:class,
'mw-mmv-image'), 10, 10).click.perform
+ rescue
+ # Plain click for web drivers that don't support mouse moves (Safari,
currently)
+ on(E2ETestPage).mmv_image_div_element.when_present.click
+ end
end
end
--
To view, visit https://gerrit.wikimedia.org/r/190811
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb89b72896d29772aff893c7cde92728450cc678
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Gilles <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
