jenkins-bot has submitted this change and it was merged.
Change subject: DropdownWidget: Simplify redundant code
......................................................................
DropdownWidget: Simplify redundant code
Change-Id: Ib38be04899a67e84335dfa4713c4385b81a62f0d
---
M src/widgets/DropdownWidget.js
1 file changed, 2 insertions(+), 10 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/widgets/DropdownWidget.js b/src/widgets/DropdownWidget.js
index c26f3cc..03c1c84 100644
--- a/src/widgets/DropdownWidget.js
+++ b/src/widgets/DropdownWidget.js
@@ -103,11 +103,7 @@
*/
OO.ui.DropdownWidget.prototype.onClick = function ( e ) {
if ( !this.isDisabled() && e.which === 1 ) {
- if ( this.menu.isVisible() ) {
- this.menu.toggle( false );
- } else {
- this.menu.toggle( true );
- }
+ this.menu.toggle();
}
return false;
};
@@ -119,11 +115,7 @@
*/
OO.ui.DropdownWidget.prototype.onKeyPress = function ( e ) {
if ( !this.isDisabled() && ( e.which === OO.ui.Keys.SPACE || e.which
=== OO.ui.Keys.ENTER ) ) {
- if ( this.menu.isVisible() ) {
- this.menu.toggle( false );
- } else {
- this.menu.toggle( true );
- }
+ this.menu.toggle();
}
return false;
};
--
To view, visit https://gerrit.wikimedia.org/r/190478
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib38be04899a67e84335dfa4713c4385b81a62f0d
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
