Amire80 has uploaded a new change for review. https://gerrit.wikimedia.org/r/191019
Change subject: [BrowserTest] Fix ParenthesesAsGroupedExpression Rubocop failures ...................................................................... [BrowserTest] Fix ParenthesesAsGroupedExpression Rubocop failures Change-Id: I7a6fbe0aefdd9abe3b0e7c42cc372487255f581b --- M .rubocop_todo.yml M modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb M modules/ve-mw/tests/browser/features/step_definitions/media_interface_steps.rb M modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb 4 files changed, 6 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/19/191019/1 diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index f16ed44..d7490b7 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -9,10 +9,6 @@ Lint/AmbiguousRegexpLiteral: Enabled: false -# Offense count: 6 -Lint/ParenthesesAsGroupedExpression: - Enabled: false - # Offense count: 3 Metrics/AbcSize: Max: 20 diff --git a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb index a0b1a0e..6ed8eb7 100644 --- a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb +++ b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb @@ -8,7 +8,7 @@ on(VisualEditorPage).media_image_element.when_present.click end -Given (/^I go to "(.+)" page which has references$/) do |page_title| +Given(/^I go to "(.+)" page which has references$/) do |page_title| wikitext = 'VisualEditor is a MediaWiki extension.<ref>[http://www.mediawiki.org/wiki/Extension:VisualEditor Extension:VisualEditor]</ref>' on(APIPage).create page_title, wikitext step "I go to the #{page_title} page for screenshot" @@ -60,7 +60,7 @@ on(VisualEditorPage).special_character_element.when_present.click end -When (/^I click on list and indentation dropdown$/) do +When(/^I click on list and indentation dropdown$/) do on(VisualEditorPage).bullet_number_selector_element.when_present.click end @@ -352,7 +352,7 @@ ) end -Then (/^I should see Cite dropdown menu$/) do +Then(/^I should see Cite dropdown menu$/) do on(VisualEditorPage).cite_pull_down_element.when_present.should be_visible Screenshot.capture( @browser, diff --git a/modules/ve-mw/tests/browser/features/step_definitions/media_interface_steps.rb b/modules/ve-mw/tests/browser/features/step_definitions/media_interface_steps.rb index f019811..a58ae0c 100644 --- a/modules/ve-mw/tests/browser/features/step_definitions/media_interface_steps.rb +++ b/modules/ve-mw/tests/browser/features/step_definitions/media_interface_steps.rb @@ -18,11 +18,11 @@ on(VisualEditorPage).media_select_element.when_present(20).click end -When (/^I click Use this image/) do +When(/^I click Use this image/) do on(VisualEditorPage).use_image_button_element.when_present.click end -When (/^I click Insert$/) do +When(/^I click Insert$/) do on(VisualEditorPage).media_insert_button_element.when_present.click end diff --git a/modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb b/modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb index 54e4cdd..496a28d 100644 --- a/modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb +++ b/modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb @@ -3,7 +3,7 @@ include PageObject include URL - page_url ('http://<%=params[:site]%>/wiki/asdfdgfghlkj?veaction=edit') + page_url('http://<%=params[:site]%>/wiki/asdfdgfghlkj?veaction=edit') div(:ve_editing_surface, class: 've-ui-surface ve-init-mw-viewPageTarget-surface') div(:ve_editing_toolbar, class: 'oo-ui-toolbar-bar') -- To view, visit https://gerrit.wikimedia.org/r/191019 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7a6fbe0aefdd9abe3b0e7c42cc372487255f581b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Amire80 <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
