Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/191058
Change subject: Only get a Title instead of a SpecialPage object
......................................................................
Only get a Title instead of a SpecialPage object
Change-Id: Ic009bbe02c4bdb22d948c92ef54b86ace51d5384
---
M repo/includes/View/SectionEditLinkGenerator.php
1 file changed, 7 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/58/191058/1
diff --git a/repo/includes/View/SectionEditLinkGenerator.php
b/repo/includes/View/SectionEditLinkGenerator.php
index f82a148..c5513fc 100644
--- a/repo/includes/View/SectionEditLinkGenerator.php
+++ b/repo/includes/View/SectionEditLinkGenerator.php
@@ -3,7 +3,7 @@
namespace Wikibase\Repo\View;
use Message;
-use SpecialPageFactory;
+use SpecialPage;
use Wikibase\Template\TemplateFactory;
/**
@@ -111,16 +111,14 @@
* @return string
*/
private function getEditUrl( $specialPageName, array
$specialPageUrlParams ) {
- if ( $specialPageName !== null && !empty( $specialPageUrlParams
) ) {
- $specialPage = SpecialPageFactory::getPage(
$specialPageName );
-
- if ( $specialPage !== null ) {
- $subPage = implode( '/', array_map(
'wfUrlencode', $specialPageUrlParams ) );
- return $specialPage->getPageTitle( $subPage
)->getLocalURL();
- }
+ if ( $specialPageName === null || empty( $specialPageUrlParams
) ) {
+ return null;
}
- return null;
+ $subPage = implode( '/', array_map( 'wfUrlencode',
$specialPageUrlParams ) );
+ $specialPageTitle = SpecialPage::getTitleFor( $specialPageName,
$subPage );
+
+ return $specialPageTitle->getLocalURL();
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/191058
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic009bbe02c4bdb22d948c92ef54b86ace51d5384
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
