Cscott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/191204
Change subject: [BREAKING CHANGE] ButtonWidget: remove deprecated nofollow
option alias
......................................................................
[BREAKING CHANGE] ButtonWidget: remove deprecated nofollow option alias
This property was renamed in I30eb9683e120224b3182e2da23e04b66c135e05a
and the old `nofollow` spelling was deprecated at that time.
Bug: T89767
Change-Id: I1d399ea48ca831b304bb5cfed994f8ee306ad123
---
M php/widgets/ButtonWidget.php
M src/widgets/ButtonWidget.js
2 files changed, 1 insertion(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/04/191204/1
diff --git a/php/widgets/ButtonWidget.php b/php/widgets/ButtonWidget.php
index 934aaab..490e48b 100644
--- a/php/widgets/ButtonWidget.php
+++ b/php/widgets/ButtonWidget.php
@@ -60,10 +60,6 @@
$this->setHref( isset( $config['href'] ) ? $config['href'] :
null );
$this->setTarget( isset( $config['target'] ) ?
$config['target'] : null );
$this->setNoFollow( isset( $config['noFollow'] ) ?
$config['noFollow'] : true );
- // FIXME: The `nofollow` alias is deprecated and will be
removed (T89767)
- if ( isset( $config['nofollow'] ) ) {
- $this->setNoFollow( $config['nofollow'] );
- }
}
/**
diff --git a/src/widgets/ButtonWidget.js b/src/widgets/ButtonWidget.js
index 2e07f64..5bd0304 100644
--- a/src/widgets/ButtonWidget.js
+++ b/src/widgets/ButtonWidget.js
@@ -24,8 +24,7 @@
*/
OO.ui.ButtonWidget = function OoUiButtonWidget( config ) {
// Configuration initialization
- // FIXME: The `nofollow` alias is deprecated and will be removed
(T89767)
- config = $.extend( { noFollow: config && config.nofollow }, config );
+ config = config || {};
// Parent constructor
OO.ui.ButtonWidget.super.call( this, config );
--
To view, visit https://gerrit.wikimedia.org/r/191204
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d399ea48ca831b304bb5cfed994f8ee306ad123
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
