tosfos has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/191206

Change subject: sort by last modified column
......................................................................

sort by last modified column

Change-Id: I8561ba75058f7ddc29b4ade51ad37e90558431bc
---
M PagesList.class.php
M PagesList.php
2 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PagesList 
refs/changes/06/191206/1

diff --git a/PagesList.class.php b/PagesList.class.php
index cad50ef..1f8bc7e 100644
--- a/PagesList.class.php
+++ b/PagesList.class.php
@@ -60,7 +60,6 @@
        /**
         * The index to actually be used for ordering. This is a single column,
         * for one ordering, even if multiple orderings are supported.
-        * @todo fixme
         * @var string
         */
        protected $indexField = 'rev_timestamp';
@@ -131,7 +130,7 @@
                $options = isset( $info['options'] ) ? $info['options'] : 
array();
                $join_conds = isset( $info['join_conds'] ) ? 
$info['join_conds'] : array();
 
-               #$options['ORDER BY'] = $this->indexField . ' DESC';
+               $options['ORDER BY'] = $this->indexField . ' DESC';
 
                return array( $tables, $fields, $conds, $fname, $options, 
$join_conds );
        }
diff --git a/PagesList.php b/PagesList.php
index c332498..9918805 100644
--- a/PagesList.php
+++ b/PagesList.php
@@ -6,7 +6,7 @@
  *
  * @file
  * @ingroup Extensions
- * @author Ike Hecht, 2014
+ * @author Ike Hecht, 2015
  * @license GNU General Public Licence 2.0 or later
  */
 $wgExtensionCredits['other'][] = array(
@@ -15,7 +15,7 @@
        'author' => array(
                'Ike Hecht',
        ),
-       'version' => '0.1.0',
+       'version' => '0.1.1',
        'url' => 'https://www.mediawiki.org/wiki/Extension:PagesList',
        'descriptionmsg' => 'pageslist-desc',
 );
@@ -68,7 +68,8 @@
  *
  * Example:
  * $wgPagesListDataTablesOptions = array(
- *     'iDisplayLength' => 25
+ *     'iDisplayLength' => 25,
+ *     'aaSorting' => array() // Don't sort by first column - results in sort 
by "last modified", descending
  * );
  */
 $wgPagesListDataTablesOptions = array();

-- 
To view, visit https://gerrit.wikimedia.org/r/191206
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8561ba75058f7ddc29b4ade51ad37e90558431bc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PagesList
Gerrit-Branch: master
Gerrit-Owner: tosfos <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to