Deskana has uploaded a new change for review.
https://gerrit.wikimedia.org/r/191537
Change subject: Correct misleading comment in handleIntent method in
PageActivity
......................................................................
Correct misleading comment in handleIntent method in PageActivity
This patch corrects a slightly misleading, but technically correct, comment in
the handleIntent method in PageActivity. The comment implies that the else
statement only executes when the app is handled an Intent it doesn't
recognise, which is not actually the case. Through doing some testing using
breakpoints, I've found out that this else statement is also triggered if the
user taps on the app from their home screen, which is far from out of the
ordinary!
This is a pretty subjective matter, so I intentionally made this change in a
separate commit from the other commit I just made that touches this area of
the code. Feel free to tell me I'm silly and that I should abandon this. :-)
Change-Id: If2b514d1f32a37a5baa46518251cc74c17bf726e
---
M wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/37/191537/1
diff --git a/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
b/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
index 73555a8..0aba697 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
@@ -383,8 +383,8 @@
HistoryEntry historyEntry = new HistoryEntry(title,
HistoryEntry.SOURCE_SEARCH);
displayNewPage(title, historyEntry);
} else {
- // Unrecognized, let us load the main page!
- // FIXME: Design something better for this?
+ // Unrecognized Intent was handled, or the user opened the app by
tapping on the icon.
+ // Let us load the main page!
displayMainPage();
}
if (intent.hasExtra(EXTRA_SEARCH_FROM_WIDGET)) {
--
To view, visit https://gerrit.wikimedia.org/r/191537
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If2b514d1f32a37a5baa46518251cc74c17bf726e
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Deskana <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
