jenkins-bot has submitted this change and it was merged. Change subject: Fix 'Thank' title text being lower case ......................................................................
Fix 'Thank' title text being lower case * Actually use flow-thank-link * Remove text-transform: capitalize. This was hiding the error since it only applied to the actual text, not the title text. Also, if this is needed, that is a sign we might not be following https://www.mediawiki.org/wiki/Localisation#Avoid_message_reuse . Change-Id: I76758fab8f06461891e24d725e25785570e922e9 --- M i18n/qqq.json M includes/UrlGenerator.php M modules/styles/board/topic/post.less 3 files changed, 2 insertions(+), 3 deletions(-) Approvals: Matthias Mullie: Looks good to me, approved jenkins-bot: Verified diff --git a/i18n/qqq.json b/i18n/qqq.json index 6353546..19b9625 100644 --- a/i18n/qqq.json +++ b/i18n/qqq.json @@ -68,7 +68,7 @@ "flow-reply-topic-title-placeholder": "Used as placeholder for the content textarea when replying. Parameters:\n* $1 - When writing a top-level reply, the topic title. When replying to a comment, the first words of the comment to which the reply is being written.\n{{Identical|Reply to}}", "flow-reply-submit": "Used as label for the Submit button. Parameters:\n* $1 - username, can be used for GENDER\nAlso used in:\n* {{msg-mw|Flow-terms-of-use-reply}}\n* {{msg-mw|Wikimedia-flow-terms-of-use-reply}}\n{{Identical|Reply}}", "flow-reply-link": "Text for the link that appears near the post and offers the user to reply to it. Clicking the link will display the reply editor. Parameters:\n* $1 - username, can be used for GENDER\n{{Identical|Reply}}", - "flow-thank-link": "Link text of the button that will (when clicked) thank the editor of the comment Parameters:\n* $1 - username, can be used for GENDER\n{{Identical|Thank}}", + "flow-thank-link": "Link and title text of the button that will (when clicked) thank the editor of the comment Parameters:\n* $1 - username, can be used for GENDER\n{{Identical|Thank}}", "flow-lock-link": "Text for the link for closing topic/post. Parameters:\n* $1 - username, can be used for GENDER\n{{Identical|Lock}}", "flow-history-action-suppress-post": "Text link for suppressing a post or topic from the board history page.\n\nFor meaning of \"suppress\" see [[Thread:Support/About MediaWiki:Flow-post-action-suppress-post/qqq]] and [[Thread:Support/About MediaWiki:Flow-suppress-post-content/sv]].\n\n{{Identical|Suppress}}", "flow-history-action-delete-post": "Text link for deleting a post or topic from the board history page.\n{{Identical|Delete}}", diff --git a/includes/UrlGenerator.php b/includes/UrlGenerator.php index 24b3a18..dc2b497 100644 --- a/includes/UrlGenerator.php +++ b/includes/UrlGenerator.php @@ -724,7 +724,7 @@ public function thankAction( UUID $postId ) { return new Anchor( - wfMessage( 'thanks-thank' ), + wfMessage( 'flow-thank-link' ), SpecialPage::getTitleFor( 'Thanks', 'Flow/' . $postId->getAlphadecimal() ) ); } diff --git a/modules/styles/board/topic/post.less b/modules/styles/board/topic/post.less index 90b0332..5080b3b 100644 --- a/modules/styles/board/topic/post.less +++ b/modules/styles/board/topic/post.less @@ -134,7 +134,6 @@ .flow-post-meta-actions { float: left; - text-transform: capitalize; a { &::after { content: "\2022"; -- To view, visit https://gerrit.wikimedia.org/r/191241 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76758fab8f06461891e24d725e25785570e922e9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: Mattflaschen <[email protected]> Gerrit-Reviewer: EBernhardson <[email protected]> Gerrit-Reviewer: Matthias Mullie <[email protected]> Gerrit-Reviewer: SG <[email protected]> Gerrit-Reviewer: Siebrand <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
