Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/191595
Change subject: Schedule a LinksUpdate job if sitelinks changed
......................................................................
Schedule a LinksUpdate job if sitelinks changed
And no longer purge the page.
We handle langlinks using ParserOuput these days
so that this is fine for the UI and it also makes
the API output (action=query&prop=langlinks) work.
Bug: T89903
Change-Id: I6b8b7bce1f2843af0fa43db24af9c71a2c3e875c
---
M client/includes/Changes/ChangeHandler.php
1 file changed, 1 insertion(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/95/191595/1
diff --git a/client/includes/Changes/ChangeHandler.php
b/client/includes/Changes/ChangeHandler.php
index c80637d..54ab31b 100644
--- a/client/includes/Changes/ChangeHandler.php
+++ b/client/includes/Changes/ChangeHandler.php
@@ -206,14 +206,7 @@
$all = isset( $aspects[EntityUsage::ALL_USAGE] );
if ( isset( $aspects[EntityUsage::SITELINK_USAGE] ) || $all ) {
- // @fixme: LinksUpdate doesn't seem to work to refresh
site links
- // when used on it's own with out parsing.
- // LinksUpdate or our interaction with it should be
changed
- // so that site links can be updated without parse.
- // For now, we need to still do parse for site link
changes.
- //
- // $actions[self::LINKS_UPDATE_ACTION] = true;
- $actions[self::PARSER_PURGE_ACTION] = true;
+ $actions[self::LINKS_UPDATE_ACTION] = true;
}
if ( isset( $aspects[EntityUsage::LABEL_USAGE] ) || $all ) {
@@ -234,11 +227,6 @@
$actions[self::WEB_PURGE_ACTION] = true;
$actions[self::RC_ENTRY_ACTION] = true;
$actions[self::HISTORY_ENTRY_ACTION] = true;
- }
-
- // If we purge the parser cache, the links update is redundant.
- if ( isset( $actions[self::PARSER_PURGE_ACTION] ) ) {
- unset( $actions[self::LINKS_UPDATE_ACTION] );
}
return array_keys( $actions );
--
To view, visit https://gerrit.wikimedia.org/r/191595
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b8b7bce1f2843af0fa43db24af9c71a2c3e875c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
