[MediaWiki-commits] [Gerrit] Drop trivial SpecialModifyEntity::getSummary method - change (mediawiki...Wikibase)

[WMDE]

Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/191602

Change subject: Drop trivial SpecialModifyEntity::getSummary method
......................................................................

Drop trivial SpecialModifyEntity::getSummary method

This reduces the dependency of the sub classes from the abstract
base class. Not much, but it helps. More to come.

Change-Id: Ia3781a545d38e37634b88dd5766d935783eadca7
---
M repo/includes/specials/SpecialModifyEntity.php
M repo/includes/specials/SpecialSetAliases.php
M repo/includes/specials/SpecialSetDescription.php
M repo/includes/specials/SpecialSetLabel.php
M repo/includes/specials/SpecialSetSiteLink.php
5 files changed, 5 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/02/191602/1

diff --git a/repo/includes/specials/SpecialModifyEntity.php 
b/repo/includes/specials/SpecialModifyEntity.php
index 6b0fd7a..adb4832 100644
--- a/repo/includes/specials/SpecialModifyEntity.php
+++ b/repo/includes/specials/SpecialModifyEntity.php
@@ -239,17 +239,6 @@
        }
 
        /**
-        * Returns the summary for the given module.
-        *
-        * @param string|null $module
-        *
-        * @return Summary
-        */
-       protected function getSummary( $module = null ) {
-               return new Summary( $module );
-       }
-
-       /**
         * Validates form input.
         *
         * The default implementation just checks whether a target entity was 
specified via a POST request.
diff --git a/repo/includes/specials/SpecialSetAliases.php 
b/repo/includes/specials/SpecialSetAliases.php
index f78d2ee..ea5dafd 100644
--- a/repo/includes/specials/SpecialSetAliases.php
+++ b/repo/includes/specials/SpecialSetAliases.php
@@ -58,7 +58,8 @@
         * @return Summary
         */
        protected function setValue( $entity, $languageCode, $value ) {
-               $summary = $this->getSummary( 'wbsetaliases' );
+               $summary = new Summary( 'wbsetaliases' );
+
                if ( $value === '' ) {
                        $changeOp = 
$this->termChangeOpFactory->newRemoveAliasesOp( $languageCode, 
$entity->getAliases( $languageCode ) );
                } else {
diff --git a/repo/includes/specials/SpecialSetDescription.php 
b/repo/includes/specials/SpecialSetDescription.php
index 85af159..c64f6f9 100644
--- a/repo/includes/specials/SpecialSetDescription.php
+++ b/repo/includes/specials/SpecialSetDescription.php
@@ -59,7 +59,7 @@
         */
        protected function setValue( $entity, $languageCode, $value ) {
                $value = $value === '' ? null : $value;
-               $summary = $this->getSummary( 'wbsetdescription' );
+               $summary = new Summary( 'wbsetdescription' );
 
                if ( $value === null ) {
                        $changeOp = 
$this->termChangeOpFactory->newRemoveDescriptionOp( $languageCode );
diff --git a/repo/includes/specials/SpecialSetLabel.php 
b/repo/includes/specials/SpecialSetLabel.php
index 02edd9f..68825ac 100644
--- a/repo/includes/specials/SpecialSetLabel.php
+++ b/repo/includes/specials/SpecialSetLabel.php
@@ -59,7 +59,7 @@
         */
        protected function setValue( $entity, $languageCode, $value ) {
                $value = $value === '' ? null : $value;
-               $summary = $this->getSummary( 'wbsetlabel' );
+               $summary = new Summary( 'wbsetlabel' );
 
                if ( $value === null ) {
                        $changeOp = 
$this->termChangeOpFactory->newRemoveLabelOp( $languageCode );
diff --git a/repo/includes/specials/SpecialSetSiteLink.php 
b/repo/includes/specials/SpecialSetSiteLink.php
index 095c0a2..7518284 100644
--- a/repo/includes/specials/SpecialSetSiteLink.php
+++ b/repo/includes/specials/SpecialSetSiteLink.php
@@ -451,7 +451,7 @@
                        return $status;
                }
 
-               $summary = $this->getSummary( 'wbsetsitelink' );
+               $summary = new Summary( 'wbsetsitelink' );
 
                if ( $pageName === '' ) {
                        $pageName = null;

-- 
To view, visit https://gerrit.wikimedia.org/r/191602
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3781a545d38e37634b88dd5766d935783eadca7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits