Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/191628
Change subject: In Gallery, provide a white background for images with
transparency.
......................................................................
In Gallery, provide a white background for images with transparency.
Bug: T87250
Change-Id: I2181088796c871e13b96a585cd3812bb65d361a6
---
M wikipedia/src/main/java/org/wikipedia/page/gallery/GalleryItemFragment.java
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/28/191628/1
diff --git
a/wikipedia/src/main/java/org/wikipedia/page/gallery/GalleryItemFragment.java
b/wikipedia/src/main/java/org/wikipedia/page/gallery/GalleryItemFragment.java
index 481f4bc..b6d8840 100644
---
a/wikipedia/src/main/java/org/wikipedia/page/gallery/GalleryItemFragment.java
+++
b/wikipedia/src/main/java/org/wikipedia/page/gallery/GalleryItemFragment.java
@@ -5,6 +5,7 @@
import org.wikipedia.WikipediaApp;
import org.wikipedia.concurrency.SaneAsyncTask;
import org.wikipedia.util.ShareUtils;
+import android.graphics.Color;
import android.graphics.drawable.BitmapDrawable;
import android.os.Bundle;
import android.provider.MediaStore;
@@ -218,6 +219,12 @@
return;
}
updateProgressBar(false, true, 0);
+ // if it's an SVG or PNG, give it a white background,
since most
+ // images with transparency were intended to be viewed
on white.
+ if (galleryItem.getMimeType().contains("svg")
+ || galleryItem.getMimeType().contains("png")) {
+ mainImage.setBackgroundColor(Color.WHITE);
+ }
attacher.update();
scaleImageToWindow();
parentActivity.supportInvalidateOptionsMenu();
--
To view, visit https://gerrit.wikimedia.org/r/191628
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2181088796c871e13b96a585cd3812bb65d361a6
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
