Chad has uploaded a new change for review.
https://gerrit.wikimedia.org/r/191653
Change subject: SpecialLinkSearch: clean up munged query variable handling
......................................................................
SpecialLinkSearch: clean up munged query variable handling
- Drop m prefix, it's silly
- Give it a default value so it doesn't complain about undefined variables
Change-Id: I378ffe304a5b29d4f35821c1f867d3a26caf5223
---
M includes/specials/SpecialLinkSearch.php
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/53/191653/1
diff --git a/includes/specials/SpecialLinkSearch.php
b/includes/specials/SpecialLinkSearch.php
index f6cb84d..20aac18 100644
--- a/includes/specials/SpecialLinkSearch.php
+++ b/includes/specials/SpecialLinkSearch.php
@@ -27,6 +27,8 @@
* @ingroup SpecialPage
*/
class LinkSearchPage extends QueryPage {
+ /** @var array|bool */
+ private $mungedQuery = false;
/**
* @var PageLinkRenderer
@@ -162,7 +164,7 @@
'namespace' => $namespace,
'protocol' => $protocol ) );
parent::execute( $par );
- if ( $this->mMungedQuery === false ) {
+ if ( $this->mungedQuery === false ) {
$out->addWikiMsg( 'linksearch-error' );
}
}
@@ -221,13 +223,13 @@
$dbr = wfGetDB( DB_SLAVE );
// strip everything past first wildcard, so that
// index-based-only lookup would be done
- list( $this->mMungedQuery, $clause ) = self::mungeQuery(
$this->mQuery, $this->mProt );
- if ( $this->mMungedQuery === false ) {
+ list( $this->mungedQuery, $clause ) = self::mungeQuery(
$this->mQuery, $this->mProt );
+ if ( $this->mungedQuery === false ) {
// Invalid query; return no results
return array( 'tables' => 'page', 'fields' =>
'page_id', 'conds' => '0=1' );
}
- $stripped = LinkFilter::keepOneWildcard( $this->mMungedQuery );
+ $stripped = LinkFilter::keepOneWildcard( $this->mungedQuery );
$like = $dbr->buildLike( $stripped );
$retval = array(
'tables' => array( 'page', 'externallinks' ),
--
To view, visit https://gerrit.wikimedia.org/r/191653
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I378ffe304a5b29d4f35821c1f867d3a26caf5223
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
