Vikassy has uploaded a new change for review.
https://gerrit.wikimedia.org/r/191655
Change subject: [BrowserTest] Edited language screenshot steps which had iframe
elements
......................................................................
[BrowserTest] Edited language screenshot steps which had iframe elements
Bug: T89370
Change-Id: If87d30fc23bfc867e6c62a3edefc8b2591c6ce48
---
M modules/ve-mw/tests/browser/features/language_screenshot.feature
M
modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
3 files changed, 7 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/55/191655/1
diff --git a/modules/ve-mw/tests/browser/features/language_screenshot.feature
b/modules/ve-mw/tests/browser/features/language_screenshot.feature
index fd246ea..5d403c7 100644
--- a/modules/ve-mw/tests/browser/features/language_screenshot.feature
+++ b/modules/ve-mw/tests/browser/features/language_screenshot.feature
@@ -82,6 +82,7 @@
Scenario: VisualEditor_Media_caption_editing
Given I go to the "Media Interface Screenshot" page with source content
"Media Interface Screenshot"
And I select an image by searching San Francisco in Media option
+ And I click Use this image
And I enter "San Francisco" in alternative text
When I enter "San Francisco is located on the West Coast of the United
States" in caption text box
Then I should see media caption dialog box
@@ -89,6 +90,7 @@
Scenario: VisualEditor_Media_advanced_settings
Given I go to the "Media Interface Screenshot" page with source content
"Media Interface Screenshot"
And I select an image by searching San Francisco in Media option
+ And I click Use this image
When I click on Advanced Settings tab
Then I should see media advanced settings dialog box
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
index 6ed8eb7..d600355 100644
---
a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
+++
b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
@@ -76,10 +76,6 @@
on(VisualEditorPage).media_advanced_settings_element.when_present.click
end
-When(/^I click on Insert media button$/) do
- on(VisualEditorPage).insert_media_element.when_present.click
-end
-
When(/^I click on Cite menu$/) do
on(VisualEditorPage).cite_indicator_down_element.when_present.click
end
@@ -328,8 +324,7 @@
Screenshot.capture(
@browser,
"VisualEditor_Media_alternative_text-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
- [@current_page.media_alternative_block_element],
- @current_page.window_frame_element
+ [@current_page.media_alternative_block_element]
)
end
diff --git
a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
index 1f9100c..dde36ca 100644
--- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
@@ -179,12 +179,9 @@
div(:visual_editor_toolbar, class: 'oo-ui-toolbar-tools')
text_area(:wikitext_editor, id: 'wpTextbox1')
text_area(:formula_area, css: '.oo-ui-popupWidget-popup textarea')
+ text_field(:media_alternative_text, css:
'div.oo-ui-widget.oo-ui-widget-enabled.oo-ui-inputWidget.oo-ui-textInputWidget.ve-ui-mwMediaDialog-altText
> input')
+ div(:content_box, class: 've-ce-documentNode ve-ce-branchNode noime')
+ div(:media_alternative_block, class: 'oo-ui-layout oo-ui-iconElement
oo-ui-labelElement oo-ui-fieldsetLayout', index: 2)
+ div(:media_advanced_settings, class: 'oo-ui-outlineOptionWidget-level-0',
index: 1)
- in_iframe(index: 0) do |frame|
- # USED IN LANGUAGE SCREENSHOT TEST:
- text_field(:media_alternative_text, css:
'div.oo-ui-widget.oo-ui-widget-enabled.oo-ui-inputWidget.oo-ui-textInputWidget.ve-ui-mwMediaDialog-altText
> input', frame: frame)
- div(:media_alternative_block, class: 'oo-ui-layout oo-ui-iconElement
oo-ui-labelElement oo-ui-fieldsetLayout', index: 1, frame: frame)
- list_item(:media_advanced_settings, class: 'oo-ui-widget
oo-ui-widget-enabled oo-ui-optionWidget oo-ui-decoratedOptionWidget
oo-ui-outlineItemWidget oo-ui-outlineItemWidget-level-0 oo-ui-iconElement
oo-ui-labelElement', frame: frame)
- a(:insert_media, css: 'div.oo-ui-processDialog-actions-primary >
div.oo-ui-buttonElement-frameless > a', frame: frame)
- end
end
--
To view, visit https://gerrit.wikimedia.org/r/191655
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If87d30fc23bfc867e6c62a3edefc8b2591c6ce48
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Vikassy <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
