Brion VIBBER has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/191698

Change subject: Enable search-replace dialog on IE 11+
......................................................................

Enable search-replace dialog on IE 11+

The search-replace box in WikiEditor was blacklisted entirely from
MSIE, although it appears to work fine in IE 11 on Windows 8.1
and Windows 10 Tech Preview.

IE/Spartan team specifically requested a fix for this bug; looks like
it's an easy case of adjusting the blacklist with a version component...

(Note that in RTL the dialog positioning is bad, but that affects
other WikiEditor dialogs too.)

Bug: T88875
Change-Id: I4cf1eb76cc8a788cab233fe9ed04aaeba4af5725
---
M modules/jquery.wikiEditor.dialogs.config.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor 
refs/changes/98/191698/1

diff --git a/modules/jquery.wikiEditor.dialogs.config.js 
b/modules/jquery.wikiEditor.dialogs.config.js
index e593baf..5ae4dbf 100644
--- a/modules/jquery.wikiEditor.dialogs.config.js
+++ b/modules/jquery.wikiEditor.dialogs.config.js
@@ -1098,7 +1098,7 @@
                                'browsers': {
                                        // Left-to-right languages
                                        'ltr': {
-                                               'msie': false,
+                                               'msie': [['>=', 11]], // Known 
to work on 11.
                                                'firefox': [['>=', 2]],
                                                'opera': false,
                                                'safari': [['>=', 3]],
@@ -1106,7 +1106,7 @@
                                        },
                                        // Right-to-left languages
                                        'rtl': {
-                                               'msie': false,
+                                               'msie': [['>=', 11]], // Works 
on 11 but dialog positioning is cruddy.
                                                'firefox': [['>=', 2]],
                                                'opera': false,
                                                'safari': [['>=', 3]],

-- 
To view, visit https://gerrit.wikimedia.org/r/191698
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cf1eb76cc8a788cab233fe9ed04aaeba4af5725
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to