jenkins-bot has submitted this change and it was merged.

Change subject: Hide MediaWiki's clickable link for section headers
......................................................................


Hide MediaWiki's clickable link for section headers

Being added in I562e437e, presumably MF doesn't want it in that form.

Added to ApiParseExtender to remove it from mobile output, added a CSS
file to hide it in desktop output.

Change-Id: Id2d939ba860997264a12a8e2fab0ce1adf0f36a0
---
M includes/Resources.php
M includes/api/ApiParseExtender.php
A less/content/sectionAnchor.less
3 files changed, 9 insertions(+), 1 deletion(-)

Approvals:
  Polybuildr: Looks good to me, but someone else must approve
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Resources.php b/includes/Resources.php
index 64afc0d..cde80ce 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -1734,6 +1734,9 @@
 );
 
 $wgResourceModuleSkinStyles['minerva'] = $wgMFResourceBoilerplate + array(
+       'mediawiki.sectionAnchor' => array(
+               'less/content/sectionAnchor.less',
+       ),
        'mediawiki.skinning.content.parsoid' => array(),
        'mobile.special.userprofile.styles' => array(
                'less/specials/userprofile.less',
diff --git a/includes/api/ApiParseExtender.php 
b/includes/api/ApiParseExtender.php
index 3350d6e..a8f1d7f 100644
--- a/includes/api/ApiParseExtender.php
+++ b/includes/api/ApiParseExtender.php
@@ -94,7 +94,8 @@
                                $mf->setIsMainPage( $params['mainpage'] && 
$wgMFSpecialCaseMainPage );
                                $mf->enableExpandableSections( 
!$params['mainpage'] );
                                // HACK: need a nice way to request a TOC- and 
edit link-free HTML in the first place
-                               $mf->remove( array( '.toc', 'mw-editsection' ) 
);
+                               // FIXME: Should this be .mw-editsection?
+                               $mf->remove( array( '.toc', 'mw-editsection', 
'.mw-headline-anchor' ) );
                                $mf->filterContent();
 
                                if ( is_array( $text ) ) {
diff --git a/less/content/sectionAnchor.less b/less/content/sectionAnchor.less
new file mode 100644
index 0000000..5ecf896
--- /dev/null
+++ b/less/content/sectionAnchor.less
@@ -0,0 +1,4 @@
+/* Hide section anchor link until it is decided how to display it */
+.mw-headline-anchor {
+       display: none;
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/191682
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2d939ba860997264a12a8e2fab0ce1adf0f36a0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bartosz DziewoƄski <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: Polybuildr <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to