jenkins-bot has submitted this change and it was merged.
Change subject: Prevent the default action for uncollapsed linear delete
......................................................................
Prevent the default action for uncollapsed linear delete
For an uncollapsed selection, handleLinearDelete was deleting the content but
wrongly reporting that it had not, leading to the native behaviour deleting
extra content adjacent to the selection. Fix handleLinearDelete's reporting
so that preventDefault gets called on the delete/backspace keydown event.
Bug: T89933
Change-Id: I2539a0cb2e2216dca479bad405d2ded9a48ce1f3
---
M .gitreview
M src/ce/ve.ce.Surface.js
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.gitreview b/.gitreview
index 5b28d55..b36dc9e 100644
--- a/.gitreview
+++ b/.gitreview
@@ -2,5 +2,5 @@
host=gerrit.wikimedia.org
port=29418
project=VisualEditor/VisualEditor.git
-defaultbranch=master
+defaultbranch=wmf/1.25wmf17
defaultrebase=0
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index 8931621..db84ae3 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -3271,6 +3271,7 @@
// TODO: is any of this necessary?
this.focus();
this.surfaceObserver.clear();
+ return true;
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/191663
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2539a0cb2e2216dca479bad405d2ded9a48ce1f3
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: wmf/1.25wmf17
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Divec <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
