Jack Phoenix has submitted this change and it was merged.
Change subject: Remove use of DatabaseBase::strencode()
......................................................................
Remove use of DatabaseBase::strencode()
Change-Id: I7421ce4c0ce77030fe43bd479d894ecc4c9eb6f6
---
M QuestionGameHome.body.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jack Phoenix: Looks good to me, approved
jenkins-bot: Verified
diff --git a/QuestionGameHome.body.php b/QuestionGameHome.body.php
index 8220bb4..7a52c7d 100644
--- a/QuestionGameHome.body.php
+++ b/QuestionGameHome.body.php
@@ -161,7 +161,7 @@
$q_id = 0;
$sql = "SELECT q_id FROM {$dbr->tableName( 'quizgame_questions'
)} {$use_index} WHERE q_id NOT IN
- (SELECT a_q_id FROM {$dbr->tableName(
'quizgame_answers' )} WHERE a_user_name = '" . $dbr->strencode( $userName ) .
"')
+ (SELECT a_q_id FROM {$dbr->tableName(
'quizgame_answers' )} WHERE a_user_name = {$dbr->addQuotes( $userName )})
AND q_flag != " . QUIZGAME_FLAG_FLAGGED . " AND
q_user_id <> {$userId} AND q_random > $randstr ORDER by q_random LIMIT 1";
$res = $dbr->query( $sql, __METHOD__ );
$row = $dbr->fetchObject( $res );
@@ -172,7 +172,7 @@
if( $q_id == 0 ) {
$sql = "SELECT q_id FROM {$dbr->tableName(
'quizgame_questions' )} {$use_index} WHERE q_id NOT IN
- (SELECT a_q_id FROM {$dbr->tableName(
'quizgame_answers' )} WHERE a_user_name = '" . $dbr->strencode( $userName ) .
"')
+ (SELECT a_q_id FROM {$dbr->tableName(
'quizgame_answers' )} WHERE a_user_name = {$dbr->addQuotes( $userName )})
AND q_flag != " . QUIZGAME_FLAG_FLAGGED
. " AND q_user_id <> {$userId} AND q_random < $randstr ORDER by q_random LIMIT
1";
$res = $dbr->query( $sql, __METHOD__ );
$row = $dbr->fetchObject( $res );
@@ -1430,4 +1430,4 @@
$out->addHTML( $output );
}
-}
\ No newline at end of file
+}
--
To view, visit https://gerrit.wikimedia.org/r/189307
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7421ce4c0ce77030fe43bd479d894ecc4c9eb6f6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/QuizGame
Gerrit-Branch: master
Gerrit-Owner: PleaseStand <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: PleaseStand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
