Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/191767
Change subject: database: Move LoadBalancer::getConnection debugmsg to
getReaderIndex
......................................................................
database: Move LoadBalancer::getConnection debugmsg to getReaderIndex
Most of the time the early $this->mReadIndex inside getReaderIndex()
should be a hit, in which case this message isn't very useful.
This one message was filling up over 60% of the build logs (496/720 lines).
> LoadBalancer::getConnection: using server for group ''
Move it to further down in getReaderIndex() where it actually
tries and finds one.
Change-Id: Id572f2bb3a905e095fcc929a9e2c17f40f7b1b6e
---
M includes/db/LoadBalancer.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/67/191767/1
diff --git a/includes/db/LoadBalancer.php b/includes/db/LoadBalancer.php
index f357880..917d703 100644
--- a/includes/db/LoadBalancer.php
+++ b/includes/db/LoadBalancer.php
@@ -331,6 +331,8 @@
if ( $this->mReadIndex <= 0 && $this->mLoads[$i] > 0 &&
$group === false ) {
$this->mReadIndex = $i;
}
+ $serverName = $this->getServerName( $i );
+ wfDebug( __METHOD__ . ": using server $serverName for
group '$group'\n" );
}
return $i;
@@ -476,8 +478,6 @@
foreach ( $groups as $group ) {
$groupIndex = $this->getReaderIndex( $group,
$wiki );
if ( $groupIndex !== false ) {
- $serverName = $this->getServerName(
$groupIndex );
- wfDebug( __METHOD__ . ": using server
$serverName for group '$group'\n" );
$i = $groupIndex;
break;
}
--
To view, visit https://gerrit.wikimedia.org/r/191767
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id572f2bb3a905e095fcc929a9e2c17f40f7b1b6e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
