jenkins-bot has submitted this change and it was merged.
Change subject: Remove ext.wikimediaEvents.ve
......................................................................
Remove ext.wikimediaEvents.ve
ext.wikimediaEvents.ve logs timing metrics via the hacky 'TimingData' schema,
which we agreed was a misuse of EventLogging and consequently replaced with the
whole StatsV thing.
Change-Id: I627a0d5d8ccc01e81cbe9137e4773be78239452c
(cherry picked from commit 67d56d7449cbd3e3131fc66c9498b1bc2555cb3c)
---
M WikimediaEvents.php
D modules/ext.wikimediaEvents.ve.js
2 files changed, 0 insertions(+), 40 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/WikimediaEvents.php b/WikimediaEvents.php
index 5a45f4c..18984e0 100644
--- a/WikimediaEvents.php
+++ b/WikimediaEvents.php
@@ -65,13 +65,6 @@
'schema' => 'Edit',
'revision' => 10676603,
),
- 'ext.wikimediaEvents.ve' => array(
- 'scripts' => 'ext.wikimediaEvents.ve.js',
- 'dependencies' => 'ext.visualEditor.base',
- 'localBasePath' => __DIR__ . '/modules',
- 'remoteExtPath' => 'WikimediaEvents/modules',
- 'targets' => array( 'desktop', 'mobile' ),
- ),
'ext.wikimediaEvents.deprecate' => array(
'scripts' => 'ext.wikimediaEvents.deprecate.js',
'localBasePath' => __DIR__ . '/modules',
@@ -85,8 +78,6 @@
'targets' => array( 'desktop', 'mobile' ),
),
);
-
-$wgVisualEditorPluginModules[] = 'ext.wikimediaEvents.ve';
// Autoloader
diff --git a/modules/ext.wikimediaEvents.ve.js
b/modules/ext.wikimediaEvents.ve.js
deleted file mode 100644
index 450ff60..0000000
--- a/modules/ext.wikimediaEvents.ve.js
+++ /dev/null
@@ -1,31 +0,0 @@
-/*global ve*/
-
-/**
- * Track VisualEditor timing data.
- * @see https://meta.wikimedia.org/wiki/Schema:TimingData
- */
-( function ( mw ) {
- var timer = null, queue = [];
-
- if ( !ve.trackSubscribe ) {
- return;
- }
-
- function dispatch() {
- var points = [];
- while ( queue.length ) {
- points.push( queue.pop() );
- }
- mw.loader.using( 'schema.TimingData', function () {
- mw.eventLog.logEvent( 'TimingData', { points:
points.join(',') } );
- } );
- }
-
- ve.trackSubscribeAll( function ( topic, data ) {
- if ( data && data.duration ) {
- queue.push( 've.' + topic + '=' + Math.round(
data.duration ) );
- clearTimeout( timer );
- timer = setTimeout( dispatch, 2000 );
- }
- } );
-}( mediaWiki ) );
--
To view, visit https://gerrit.wikimedia.org/r/191776
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I627a0d5d8ccc01e81cbe9137e4773be78239452c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: wmf/1.25wmf18
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
