jenkins-bot has submitted this change and it was merged.
Change subject: JSLint compliance
......................................................................
JSLint compliance
slight modifications to pass jslint checking
Bug: T86573
Change-Id: Ic2e36a13a308637de3063cef4d27129179980eff
---
M resources/ajaxpoll.js
1 file changed, 52 insertions(+), 70 deletions(-)
Approvals:
Jack Phoenix: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ajaxpoll.js b/resources/ajaxpoll.js
index 75ca7f4..0b70a79 100644
--- a/resources/ajaxpoll.js
+++ b/resources/ajaxpoll.js
@@ -1,77 +1,59 @@
+/*global $, mw, useAjax*/
+
var ajaxpollTmp;
-var setupEventHandlers = function(){
- $(".ajaxpoll-answer-vote").on("mouseover",
- function(){
- var sp=$(this).find("span");
- ajaxpollTmp=sp.html();
- sp.text(sp.attr("title"));
- sp.attr("title","");
- }
- );
+var setupEventHandlers = function () {
+ "use strict";
+ $(".ajaxpoll-answer-vote").on("mouseover", function () {
+ var sp = $(this).find("span");
+ ajaxpollTmp = sp.html();
+ sp.text(sp.attr("title"));
+ sp.attr("title", "");
+ });
- $(".ajaxpoll-answer-vote").on("mouseout",
- function(){
- var sp=$(this).find("span");
- sp.attr("title",sp.text());
- sp.text(ajaxpollTmp);
- }
- );
+ $(".ajaxpoll-answer-vote").on("mouseout", function () {
+ var sp = $(this).find("span");
+ sp.attr("title", sp.text());
+ sp.text(ajaxpollTmp);
+ });
- /* attach click handler */
- $(".ajaxpoll-answer-name label")
- .on("click",
- function(event){
- event.preventDefault();
- event.stopPropagation();
- $this = $(this).parent().parent();
- var poll = $this.attr( "poll" );
- var answer = $this.attr( "answer" );
- var token =
$this.parent().find("input[name='ajaxPollToken']").val();
-
$this.find(".ajaxpoll-hover-vote").addClass("ajaxpoll-checkevent");
- $this.find("input").prop("checked","checked");
- $( "#ajaxpoll-ajax-"+poll )
- .text( mw.message(
'ajaxpoll-submitting' ).text() )
- .css("display","inline-block");
- if (useAjax){
- $.get(
- mw.util.wikiScript(),
- {
- action: 'ajax',
- rs:
"AJAXPoll::submitVote",
- rsargs:
[poll,answer,token]
- },
- function(newHTML){
-
$("#ajaxpoll-container-"+poll).html(newHTML);
- setupEventHandlers();
- }
- );
- } else {
- $("#ajaxpoll-answer-id-"+poll).submit();
- }
- }
- )
+ /* attach click handler */
+ $(".ajaxpoll-answer-name label").on("click", function (event) {
+ var choice = $(this).parent().parent(), poll, answer, token;
+ event.preventDefault();
+ event.stopPropagation();
+ poll = choice.attr("poll");
+ answer = choice.attr("answer");
+ token = choice.parent().find("input[name='ajaxPollToken']").val();
+ choice.find(".ajaxpoll-hover-vote").addClass("ajaxpoll-checkevent");
+ choice.find("input").prop("checked", "checked");
+ $("#ajaxpoll-ajax-" +
poll).text(mw.message('ajaxpoll-submitting').text()).css("display",
"inline-block");
+ if (useAjax) {
+ $.get(mw.util.wikiScript(), {
+ action : 'ajax',
+ rs : "AJAXPoll::submitVote",
+ rsargs : [ poll, answer, token ]
+ }, function (newHTML) {
+ $("#ajaxpoll-container-" + poll).html(newHTML);
+ setupEventHandlers();
+ });
+ } else {
+ $("#ajaxpoll-answer-id-" + poll).submit();
+ }
+ });
- $(".ajaxpoll-answer-name:not(.ajaxpoll-answer-name-revoke)
label").on("mouseover",
- function(){
- $(this).addClass("ajaxpoll-hover-vote");
- }
- );
- $(".ajaxpoll-answer-name:not(.ajaxpoll-answer-name-revoke)
label").on("mouseout",
- function(){
- $(this).removeClass("ajaxpoll-hover-vote");
- }
- );
+ $(".ajaxpoll-answer-name:not(.ajaxpoll-answer-name-revoke)
label").on("mouseover", function () {
+ $(this).addClass("ajaxpoll-hover-vote");
+ });
+ $(".ajaxpoll-answer-name:not(.ajaxpoll-answer-name-revoke)
label").on("mouseout", function () {
+ $(this).removeClass("ajaxpoll-hover-vote");
+ });
- $(".ajaxpoll-answer-name-revoke label").on("mouseover",
- function(){
- $(this).addClass("ajaxpoll-hover-revoke");
- }
- );
- $(".ajaxpoll-answer-name-revoke label").on("mouseout",
- function(){
- $(this).removeClass("ajaxpoll-hover-revoke");
- }
- );
-}
+ $(".ajaxpoll-answer-name-revoke label").on("mouseover", function () {
+ $(this).addClass("ajaxpoll-hover-revoke");
+ });
+ $(".ajaxpoll-answer-name-revoke label").on("mouseout", function () {
+ $(this).removeClass("ajaxpoll-hover-revoke");
+ });
+};
setupEventHandlers();
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/190755
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2e36a13a308637de3063cef4d27129179980eff
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/AJAXPoll
Gerrit-Branch: master
Gerrit-Owner: TakahashiNZ <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
