jenkins-bot has submitted this change and it was merged.
Change subject: Stylizing the JS file
......................................................................
Stylizing the JS file
s/four spaces/one tab/ and s/double quotes/single quotes/ + some
MediaWiki-esque spacing tweaks
Should pass JSHint checks now that double quotes are gone
Change-Id: Ifdf07faf8f1c2e817ce515a4ffed3e7c9699d1af
---
M resources/ajaxpoll.js
1 file changed, 48 insertions(+), 48 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ajaxpoll.js b/resources/ajaxpoll.js
index 0b70a79..002f70e 100644
--- a/resources/ajaxpoll.js
+++ b/resources/ajaxpoll.js
@@ -3,57 +3,57 @@
var ajaxpollTmp;
var setupEventHandlers = function () {
- "use strict";
- $(".ajaxpoll-answer-vote").on("mouseover", function () {
- var sp = $(this).find("span");
- ajaxpollTmp = sp.html();
- sp.text(sp.attr("title"));
- sp.attr("title", "");
- });
+ 'use strict';
+ $( '.ajaxpoll-answer-vote' ).on( 'mouseover', function () {
+ var sp = $( this ).find( 'span' );
+ ajaxpollTmp = sp.html();
+ sp.text( sp.attr( 'title' ) );
+ sp.attr( 'title', '' );
+ } );
- $(".ajaxpoll-answer-vote").on("mouseout", function () {
- var sp = $(this).find("span");
- sp.attr("title", sp.text());
- sp.text(ajaxpollTmp);
- });
+ $( '.ajaxpoll-answer-vote' ).on( 'mouseout', function () {
+ var sp = $( this ).find( 'span' );
+ sp.attr( 'title', sp.text() );
+ sp.text( ajaxpollTmp );
+ } );
- /* attach click handler */
- $(".ajaxpoll-answer-name label").on("click", function (event) {
- var choice = $(this).parent().parent(), poll, answer, token;
- event.preventDefault();
- event.stopPropagation();
- poll = choice.attr("poll");
- answer = choice.attr("answer");
- token = choice.parent().find("input[name='ajaxPollToken']").val();
- choice.find(".ajaxpoll-hover-vote").addClass("ajaxpoll-checkevent");
- choice.find("input").prop("checked", "checked");
- $("#ajaxpoll-ajax-" +
poll).text(mw.message('ajaxpoll-submitting').text()).css("display",
"inline-block");
- if (useAjax) {
- $.get(mw.util.wikiScript(), {
- action : 'ajax',
- rs : "AJAXPoll::submitVote",
- rsargs : [ poll, answer, token ]
- }, function (newHTML) {
- $("#ajaxpoll-container-" + poll).html(newHTML);
- setupEventHandlers();
- });
- } else {
- $("#ajaxpoll-answer-id-" + poll).submit();
- }
- });
+ /* attach click handler */
+ $( '.ajaxpoll-answer-name label' ).on( 'click', function ( event ) {
+ var choice = $( this ).parent().parent(), poll, answer, token;
+ event.preventDefault();
+ event.stopPropagation();
+ poll = choice.attr( 'poll' );
+ answer = choice.attr( 'answer' );
+ token = choice.parent().find( 'input[name="ajaxPollToken"]'
).val();
+ choice.find( '.ajaxpoll-hover-vote' ).addClass(
'ajaxpoll-checkevent' );
+ choice.find( 'input' ).prop( 'checked', 'checked' );
+ $( '#ajaxpoll-ajax-' + poll ).text(mw.message(
'ajaxpoll-submitting' ).text() ).css( 'display', 'inline-block' );
+ if ( useAjax ) {
+ $.get( mw.util.wikiScript(), {
+ action: 'ajax',
+ rs: 'AJAXPoll::submitVote',
+ rsargs: [ poll, answer, token ]
+ }, function ( newHTML ) {
+ $( '#ajaxpoll-container-' + poll ).html(
newHTML );
+ setupEventHandlers();
+ } );
+ } else {
+ $( '#ajaxpoll-answer-id-' + poll ).submit();
+ }
+ } );
- $(".ajaxpoll-answer-name:not(.ajaxpoll-answer-name-revoke)
label").on("mouseover", function () {
- $(this).addClass("ajaxpoll-hover-vote");
- });
- $(".ajaxpoll-answer-name:not(.ajaxpoll-answer-name-revoke)
label").on("mouseout", function () {
- $(this).removeClass("ajaxpoll-hover-vote");
- });
+ $( '.ajaxpoll-answer-name:not(.ajaxpoll-answer-name-revoke) label').on(
'mouseover', function () {
+ $( this ).addClass( 'ajaxpoll-hover-vote' );
+ } );
+ $( '.ajaxpoll-answer-name:not(.ajaxpoll-answer-name-revoke) label').on(
'mouseout', function () {
+ $( this ).removeClass( 'ajaxpoll-hover-vote' );
+ } );
- $(".ajaxpoll-answer-name-revoke label").on("mouseover", function () {
- $(this).addClass("ajaxpoll-hover-revoke");
- });
- $(".ajaxpoll-answer-name-revoke label").on("mouseout", function () {
- $(this).removeClass("ajaxpoll-hover-revoke");
- });
+ $( '.ajaxpoll-answer-name-revoke label' ).on( 'mouseover', function () {
+ $( this ).addClass( 'ajaxpoll-hover-revoke' );
+ } );
+ $( '.ajaxpoll-answer-name-revoke label' ).on( 'mouseout', function () {
+ $( this ).removeClass( 'ajaxpoll-hover-revoke' );
+ } );
};
setupEventHandlers();
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/191785
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifdf07faf8f1c2e817ce515a4ffed3e7c9699d1af
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AJAXPoll
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
