Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/191809
Change subject: Add a warning about $wgVisualEditorPluginModules race condition ...................................................................... Add a warning about $wgVisualEditorPluginModules race condition Warn developers not to delist a plugin module and remove it in a single deployment, since the relevant cache layers are not synchronized, making a race condition possible. See I627a0d5d8 for an example. Change-Id: I488bafa08a5eab6b40fa73bb5ca031fb5a6aa9ed --- M VisualEditor.php 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/09/191809/1 diff --git a/VisualEditor.php b/VisualEditor.php index 46b3f30..b499cf0 100644 --- a/VisualEditor.php +++ b/VisualEditor.php @@ -1493,6 +1493,11 @@ // Array of ResourceLoader module names (strings) that should be loaded when VisualEditor is // loaded. Other extensions that extend VisualEditor should add to this array. +// +// WARNING: When removing a module, first remove it from this array, wait for the change +// to propagate, and only then remove the module code and module registration. Otherwise +// there may be a period of time during which VisualEditor depends on a module that no +// longer exists. $wgVisualEditorPluginModules = array(); // Array of modules to load based on a preference. Keys are preference names, values are -- To view, visit https://gerrit.wikimedia.org/r/191809 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I488bafa08a5eab6b40fa73bb5ca031fb5a6aa9ed Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Ori.livneh <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
