jenkins-bot has submitted this change and it was merged.
Change subject: Add dependency on ext.ve.mw in ext.ve.mwreference
......................................................................
Add dependency on ext.ve.mw in ext.ve.mwreference
MWReferenceDialog uses ve.init.mw.Target in its setup code,
so it needs this dependency. Otherwise the tests fail intermittently;
usually only when loading from localStorage for some reason.
Change-Id: I6c0f66263e2cf6ffcf926fefaac4de1e53eac130
---
M VisualEditor.php
M extension.json
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/VisualEditor.php b/VisualEditor.php
index b499cf0..d7378fb 100644
--- a/VisualEditor.php
+++ b/VisualEditor.php
@@ -1272,6 +1272,7 @@
'dependencies' => array(
'ext.visualEditor.mwreference.core',
'ext.visualEditor.mwtransclusion',
+ 'ext.visualEditor.mediawiki'
),
'messages' => array(
'visualeditor-dialog-reference-editing-reused',
diff --git a/extension.json b/extension.json
index 583591d..bb9d970 100644
--- a/extension.json
+++ b/extension.json
@@ -1295,7 +1295,8 @@
],
"dependencies": [
"ext.visualEditor.mwreference.core",
- "ext.visualEditor.mwtransclusion"
+ "ext.visualEditor.mwtransclusion",
+ "ext.visualEditor.mediawiki"
],
"messages": [
"visualeditor-dialog-reference-editing-reused",
--
To view, visit https://gerrit.wikimedia.org/r/191788
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c0f66263e2cf6ffcf926fefaac4de1e53eac130
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
