jenkins-bot has submitted this change and it was merged.
Change subject: Fix the Rubocop offense TrailingBlankLines
......................................................................
Fix the Rubocop offense TrailingBlankLines
Done using
bundle exec rubocop -c .rubocop.yml --auto-correct
Change-Id: Ieb5d7d47056f6ca17b0016147a057ad10266b6b9
---
M .rubocop_todo.yml
M tests/browser/features/step_definitions/create_and_follow_wiki_link_steps.rb
M tests/browser/features/step_definitions/edit_page_steps.rb
M tests/browser/features/step_definitions/preferences_appearance_steps.rb
M tests/browser/features/step_definitions/preferences_user_profile_steps.rb
M tests/browser/features/step_definitions/view_history_steps.rb
M tests/browser/features/support/pages/edit_page.rb
M tests/browser/features/support/pages/login_error_page.rb
M tests/browser/features/support/pages/main_page.rb
M tests/browser/features/support/pages/preferences_appearance_page.rb
M tests/browser/features/support/pages/ztargetpage.rb
11 files changed, 4 insertions(+), 17 deletions(-)
Approvals:
Zfilipin: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index c2f548a..3edb126 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -40,9 +40,3 @@
# Configuration parameters: EnforcedStyle, SupportedStyles.
Style/StringLiterals:
Enabled: false
-
-# Offense count: 11
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/TrailingBlankLines:
- Enabled: false
diff --git
a/tests/browser/features/step_definitions/create_and_follow_wiki_link_steps.rb
b/tests/browser/features/step_definitions/create_and_follow_wiki_link_steps.rb
index 97db0ae..5271ea8 100644
---
a/tests/browser/features/step_definitions/create_and_follow_wiki_link_steps.rb
+++
b/tests/browser/features/step_definitions/create_and_follow_wiki_link_steps.rb
@@ -24,4 +24,3 @@
Then(/^the page content should contain "(.*?)"$/) do |content|
on(ZtargetPage).page_content.should match content
end
-
diff --git a/tests/browser/features/step_definitions/edit_page_steps.rb
b/tests/browser/features/step_definitions/edit_page_steps.rb
index 5ab02be..713bb39 100644
--- a/tests/browser/features/step_definitions/edit_page_steps.rb
+++ b/tests/browser/features/step_definitions/edit_page_steps.rb
@@ -21,4 +21,3 @@
Then(/^the edited page content should contain "(.*?)"$/) do |content|
on(MainPage).page_content.should match(content + @random_string)
end
-
diff --git
a/tests/browser/features/step_definitions/preferences_appearance_steps.rb
b/tests/browser/features/step_definitions/preferences_appearance_steps.rb
index 0046af6..44f87de 100644
--- a/tests/browser/features/step_definitions/preferences_appearance_steps.rb
+++ b/tests/browser/features/step_definitions/preferences_appearance_steps.rb
@@ -81,5 +81,3 @@
page.auto_number_check_element.should exist
end
end
-
-
diff --git
a/tests/browser/features/step_definitions/preferences_user_profile_steps.rb
b/tests/browser/features/step_definitions/preferences_user_profile_steps.rb
index 529af66..6ecd04f 100644
--- a/tests/browser/features/step_definitions/preferences_user_profile_steps.rb
+++ b/tests/browser/features/step_definitions/preferences_user_profile_steps.rb
@@ -40,4 +40,3 @@
Then(/^I can see my signature$/) do
on(PreferencesUserProfilePage).signature_table_element.should exist
end
-
diff --git a/tests/browser/features/step_definitions/view_history_steps.rb
b/tests/browser/features/step_definitions/view_history_steps.rb
index 1ecc008..6bb7e83 100644
--- a/tests/browser/features/step_definitions/view_history_steps.rb
+++ b/tests/browser/features/step_definitions/view_history_steps.rb
@@ -5,4 +5,3 @@
Then(/^I should see a link to a previous version of the page$/) do
on(ViewHistoryPage).old_version_link_element.should be_visible
end
-
diff --git a/tests/browser/features/support/pages/edit_page.rb
b/tests/browser/features/support/pages/edit_page.rb
index b619c34..237441e 100644
--- a/tests/browser/features/support/pages/edit_page.rb
+++ b/tests/browser/features/support/pages/edit_page.rb
@@ -5,4 +5,4 @@
button(:preview_button, id: "wpPreview")
button(:show_changes_button, id: "wpDiff")
button(:save_button, id: "wpSave")
-end
\ No newline at end of file
+end
diff --git a/tests/browser/features/support/pages/login_error_page.rb
b/tests/browser/features/support/pages/login_error_page.rb
index 4fc9ca7..fd000e6 100644
--- a/tests/browser/features/support/pages/login_error_page.rb
+++ b/tests/browser/features/support/pages/login_error_page.rb
@@ -2,4 +2,4 @@
include PageObject
div(:error_box, class: "errorbox")
-end
\ No newline at end of file
+end
diff --git a/tests/browser/features/support/pages/main_page.rb
b/tests/browser/features/support/pages/main_page.rb
index 7d96c2b..8156800 100644
--- a/tests/browser/features/support/pages/main_page.rb
+++ b/tests/browser/features/support/pages/main_page.rb
@@ -16,4 +16,4 @@
li(:special_pages_link, id: "t-specialpages")
a(:view_history_link, href: /action=history/)
li(:what_links_here_link, id: "t-whatlinkshere")
-end
\ No newline at end of file
+end
diff --git
a/tests/browser/features/support/pages/preferences_appearance_page.rb
b/tests/browser/features/support/pages/preferences_appearance_page.rb
index c24e386..ed4491e 100644
--- a/tests/browser/features/support/pages/preferences_appearance_page.rb
+++ b/tests/browser/features/support/pages/preferences_appearance_page.rb
@@ -38,4 +38,3 @@
radio_button(:vector, id: "mw-input-wpskin-vector")
radio_button(:year_mo_day_radio, id: "mw-input-wpdate-ymd")
end
-
diff --git a/tests/browser/features/support/pages/ztargetpage.rb
b/tests/browser/features/support/pages/ztargetpage.rb
index c1f46ec..7f168db 100644
--- a/tests/browser/features/support/pages/ztargetpage.rb
+++ b/tests/browser/features/support/pages/ztargetpage.rb
@@ -4,4 +4,4 @@
include PageObject
a(:link_target_page_link, text: "link to the test target page")
-end
\ No newline at end of file
+end
--
To view, visit https://gerrit.wikimedia.org/r/191615
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb5d7d47056f6ca17b0016147a057ad10266b6b9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il>
Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
