jenkins-bot has submitted this change and it was merged.
Change subject: zuul: test 'recheck' behavior
......................................................................
zuul: test 'recheck' behavior
Using the mediawiki/core project as a context, test that:
- a trusted user commenting 'recheck' enqueue a change in the test
pipeline.
- an untrusted user commenting 'recheck' does not enqueue.
Change-Id: Icdc1b4a7d5ebca26534ac20be75c49c92657e3d1
---
M tests/test_zuul_layout.py
1 file changed, 20 insertions(+), 0 deletions(-)
Approvals:
Hashar: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/test_zuul_layout.py b/tests/test_zuul_layout.py
index 9eaceeb..6ea9c0f 100644
--- a/tests/test_zuul_layout.py
+++ b/tests/test_zuul_layout.py
@@ -199,3 +199,23 @@
# We expect check pipelines to have no unsafe jobs
expected = {k: {} for k in check_pipelines}
self.assertEquals(expected, actual)
+
+ def test_recheck_comment_trusted_user(self):
+ test_manager = self.getPipeline('test').manager
+ change = zuul.model.Change('mediawiki/core')
+
+ event = zuul.model.TriggerEvent()
+ event.type = 'comment-added'
+ event.comment = 'Patch Set 1:\n\nrecheck'
+ event.account = {'email': '[email protected]'}
+ self.assertTrue(test_manager.eventMatches(event, change))
+
+ def test_recheck_comment_untrusted_user(self):
+ test_manager = self.getPipeline('test').manager
+ change = zuul.model.Change('mediawiki/core')
+
+ event = zuul.model.TriggerEvent()
+ event.type = 'comment-added'
+ event.comment = 'Patch Set 1:\n\nrecheck'
+ event.account = {'email': '[email protected]'}
+ self.assertFalse(test_manager.eventMatches(event, change))
--
To view, visit https://gerrit.wikimedia.org/r/184967
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icdc1b4a7d5ebca26534ac20be75c49c92657e3d1
Gerrit-PatchSet: 5
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
