Hashar has uploaded a new change for review.
https://gerrit.wikimedia.org/r/191881
Change subject: Remove yamllint jobs
......................................................................
Remove yamllint jobs
To lint yaml we are using python-yaml which has a few problems:
- it can load an arbitrary python object which is rather unsafe
- does not support multiple documents (T86194)
- it is only for python, not for other languages implementations we use
such as the javascript one.
Get rid of our lame YAML linter, in favor of having developers write a
test to validate their files.
Deletes:
translatewiki-yamllint
mwext-Workflow-yamllint
labs-tools-grrrit-yamllint
integration-jenkins-yamllint
integration-jjb-config-yamllint
integration-zuul-config-yamllint
mwext-ContentTranslation-yamllint
wikimedia-bots-jouncebot-yamllint
wikimedia-fundraising-tools-yamllint
Bug: T86194
Change-Id: I8e61ededf50c6ce691ffcdda35cfe6b7d09f101f
---
M jjb/job-templates.yaml
M jjb/labs.yaml
M jjb/macro.yaml
M jjb/mediawiki-extensions.yaml
M jjb/translatewiki.yaml
M jjb/wm-bots.yaml
M jjb/wm-fundraising.yaml
M zuul/layout.yaml
8 files changed, 0 insertions(+), 46 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/integration/config
refs/changes/81/191881/1
diff --git a/jjb/job-templates.yaml b/jjb/job-templates.yaml
index 3b3633f..a4ea415 100644
--- a/jjb/job-templates.yaml
+++ b/jjb/job-templates.yaml
@@ -278,19 +278,6 @@
(grep --recursive -P '^\t' --exclude-dir='.git'
--include='{fileselector}' .) && HAS_TAB=1 || HAS_TAB=0
exit $HAS_TAB
-
-- job-template:
- name: '{name}-yamllint'
- defaults: use-remote-zuul-no-submodules
- node: hasSlaveScripts && UbuntuPrecise
- concurrent: true
- logrotate:
- daysToKeep: 90
- triggers:
- - zuul
- builders:
- - yaml-lint
-
# Java checktyle for maven projects
- job-template:
name: '{name}-maven-checkstyle'
diff --git a/jjb/labs.yaml b/jjb/labs.yaml
index 530de90..90adb36 100644
--- a/jjb/labs.yaml
+++ b/jjb/labs.yaml
@@ -42,7 +42,6 @@
name: 'labs-tools-grrrit'
jobs:
- '{name}-jslint'
- - '{name}-yamllint'
- project:
name: 'labs-tools-wikibugs2'
diff --git a/jjb/macro.yaml b/jjb/macro.yaml
index 7ddb6fc..2e8c03d 100644
--- a/jjb/macro.yaml
+++ b/jjb/macro.yaml
@@ -689,11 +689,6 @@
PY_COLORS=1 tox -v -e "{venv}" | tee "log/{venv}.log"
set +o pipefail
-- builder:
- name: yaml-lint
- builders:
- - shell: '/srv/deployment/integration/slave-scripts/tools/yamllint.py
"$WORKSPACE"'
-
- publisher:
name: archive-log-dir
publishers:
diff --git a/jjb/mediawiki-extensions.yaml b/jjb/mediawiki-extensions.yaml
index 0f02b11..c45e5f8 100644
--- a/jjb/mediawiki-extensions.yaml
+++ b/jjb/mediawiki-extensions.yaml
@@ -1319,7 +1319,6 @@
bundlecommand:
- rubocop
- '{name}-ruby1.9.3lint'
- - '{name}-yamllint'
- project:
name: 'mwext-DumpHTML'
@@ -1506,11 +1505,6 @@
name: 'mwext-WikimediaMaintenance'
jobs:
- python-jobs
-
-- project:
- name: 'mwext-Workflow'
- jobs:
- - '{name}-yamllint'
- project:
name: 'mwext-ZeroBanner'
diff --git a/jjb/translatewiki.yaml b/jjb/translatewiki.yaml
index 5deb416..0827c02 100644
--- a/jjb/translatewiki.yaml
+++ b/jjb/translatewiki.yaml
@@ -32,4 +32,3 @@
- '{name}-puppetlint-strict'
- translatewiki-shelllint
- '{name}-phplint'
- - '{name}-yamllint'
diff --git a/jjb/wm-bots.yaml b/jjb/wm-bots.yaml
index 212f189..f9a8967 100644
--- a/jjb/wm-bots.yaml
+++ b/jjb/wm-bots.yaml
@@ -3,5 +3,4 @@
toxenv:
- flake8
jobs:
- - '{name}-yamllint'
- '{name}-tox-{toxenv}'
diff --git a/jjb/wm-fundraising.yaml b/jjb/wm-fundraising.yaml
index 3bbfe46..9fe334e 100644
--- a/jjb/wm-fundraising.yaml
+++ b/jjb/wm-fundraising.yaml
@@ -3,7 +3,6 @@
jobs:
- '{name}-jslint'
- - '{name}-yamllint'
- python-jobs
- project:
diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 8feed85..6bdface 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -1742,9 +1742,6 @@
- name: operations-puppet-doc
success-message: 'Documentation published on
https://doc.wikimedia.org/puppet/. Build'
- - name: wikimedia-fundraising-tools-yamllint
- voting: false
-
project-templates:
@@ -2182,10 +2179,8 @@
- name: labs/tools/grrrit
check-voter:
- labs-tools-grrrit-jslint
- - labs-tools-grrrit-yamllint
gate-and-submit:
- labs-tools-grrrit-jslint
- - labs-tools-grrrit-yamllint
- name: labs/tools/wikibugs2
test:
@@ -2659,14 +2654,12 @@
- translatewiki-puppetlint-lenient
- translatewiki-puppetlint-strict
- translatewiki-shelllint
- #- translatewiki-yamllint (Broken, T86194)
gate-and-submit:
- translatewiki-phplint
- translatewiki-puppet-validate
- translatewiki-puppetlint-lenient
- translatewiki-puppetlint-strict
- translatewiki-shelllint
- #- translatewiki-yamllint (Broken, T86194)
- name: wikimedia/bugzilla/wikibugs
# Only lint on submission for now, that will be voting
@@ -2689,10 +2682,8 @@
prefix: 'wikimedia-fundraising-tools'
check-voter:
- wikimedia-fundraising-tools-jslint
- - wikimedia-fundraising-tools-yamllint
gate-and-submit:
- wikimedia-fundraising-tools-jslint
- - wikimedia-fundraising-tools-yamllint
- name: wikimedia/fundraising/crm
check-voter:
@@ -3077,7 +3068,6 @@
- mwext-ContentTranslation-jslint
- mwext-ContentTranslation-lint
- mwext-ContentTranslation-ruby1.9.3lint
- - mwext-ContentTranslation-yamllint
- php-composer-validate
test:
- mwext-ContentTranslation-phpcs-HEAD
@@ -3085,7 +3075,6 @@
- mwext-ContentTranslation-lint
- mwext-ContentTranslation-bundle-rubocop
- mwext-ContentTranslation-ruby1.9.3lint
- - mwext-ContentTranslation-yamllint
- mwext-ContentTranslation-qunit
- php-composer-validate
gate-and-submit:
@@ -3095,7 +3084,6 @@
- mwext-ContentTranslation-lint
- mwext-ContentTranslation-bundle-rubocop
- mwext-ContentTranslation-ruby1.9.3lint
- - mwext-ContentTranslation-yamllint
- mwext-ContentTranslation-qunit
- php-composer-validate
@@ -5970,10 +5958,6 @@
- name: mediawiki/extensions/Workflow
template:
- name: extension-unittests
- test:
- - mwext-Workflow-yamllint
- gate-and-submit:
- - mwext-Workflow-yamllint
- name: mediawiki/extensions/ZeroBanner
template:
@@ -6236,7 +6220,5 @@
- name: wikimedia/bots/jouncebot
test:
- wikimedia-bots-jouncebot-tox-flake8
- - wikimedia-bots-jouncebot-yamllint
gate-and-submit:
- wikimedia-bots-jouncebot-tox-flake8
- - wikimedia-bots-jouncebot-yamllint
--
To view, visit https://gerrit.wikimedia.org/r/191881
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e61ededf50c6ce691ffcdda35cfe6b7d09f101f
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
