jenkins-bot has submitted this change and it was merged.
Change subject: Fix canvas height calculation
......................................................................
Fix canvas height calculation
Canvas height is calculated as viewport height minus above-the-fold
height but the latter did not take into account the padding. This
was probably broken last autumn when the above-the-fold contents
were rearranged, but the max-height rule on the image masked the
error so we did not notice until that rule was dropped.
Bug: T89631
Change-Id: Id53cd9c176528da33b393e5ed807d6f2e0886413
(cherry picked from commit 3bb2b8185a45fbc0c01ad53f8810fdf9ed7ca4e7)
---
M resources/mmv/ui/mmv.ui.canvas.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gergő Tisza: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mmv/ui/mmv.ui.canvas.js
b/resources/mmv/ui/mmv.ui.canvas.js
index 2a58d17..2ed1f2f 100644
--- a/resources/mmv/ui/mmv.ui.canvas.js
+++ b/resources/mmv/ui/mmv.ui.canvas.js
@@ -372,7 +372,7 @@
// Depending on what the wrapper contains, its size can
be 0 on some browsers.
// Therefore, we calculate the available space manually
availableWidth = $window.width(),
- availableHeight = $window.height() - ( isFullscreened ?
0 : $aboveFold.height() );
+ availableHeight = $window.height() - ( isFullscreened ?
0 : $aboveFold.outerHeight() );
if ( forFullscreen ) {
return {
--
To view, visit https://gerrit.wikimedia.org/r/192025
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id53cd9c176528da33b393e5ed807d6f2e0886413
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: wmf/1.25wmf18
Gerrit-Owner: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
