jenkins-bot has submitted this change and it was merged.
Change subject: Kill a couple obsolete @param tags
......................................................................
Kill a couple obsolete @param tags
Change-Id: I37bc021a0591cbf33fcc4b3242f8d2f422a67a85
---
M gateway_common/DataValidator.php
M gateway_common/GatewayPage.php
2 files changed, 0 insertions(+), 10 deletions(-)
Approvals:
Awight: Looks good to me, approved
jenkins-bot: Verified
diff --git a/gateway_common/DataValidator.php b/gateway_common/DataValidator.php
index 13f08c6..87555c6 100644
--- a/gateway_common/DataValidator.php
+++ b/gateway_common/DataValidator.php
@@ -555,7 +555,6 @@
* Anything else that is 'falseish' is still perfectly valid to have as
a data point.
* TODO: Consider doing this in a batch.
* @param string $value The value to check for non-emptyness.
- * @param array $data The whole data set.
* @return boolean True if the $value is not missing or empty,
otherwise false.
*/
protected static function validate_not_empty( $value ){
diff --git a/gateway_common/GatewayPage.php b/gateway_common/GatewayPage.php
index 85c7b65..d8ea4fe 100644
--- a/gateway_common/GatewayPage.php
+++ b/gateway_common/GatewayPage.php
@@ -76,15 +76,6 @@
* little to do with being contained within what in an ideal world
would be
* a piece of mostly UI, this function needs to be moved inside the
gateway
* adapter class.
- * @param array $options
- * OPTIONAL - In addition to all non-optional validation which
verifies
- * that all populated fields contain an appropriate data type, you
may
- * require certain field groups to be non-empty.
- * - address - Validation requires non-empty: street, city, state, zip
- * - amount - Validation requires non-empty: amount
- * - creditCard - Validation requires non-empty: card_num, cvv,
expiration and card_type
- * - email - Validation requires non-empty: email
- * - name - Validation requires non-empty: fname, lname
*
* @return boolean Returns false on an error-free validation, otherwise
true.
* FIXME: that return value seems backwards to me.
--
To view, visit https://gerrit.wikimedia.org/r/187644
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37bc021a0591cbf33fcc4b3242f8d2f422a67a85
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
