jenkins-bot has submitted this change and it was merged.
Change subject: Skip missed dependencies in
ResourcesTest::testUnsatisfiableDependencies
......................................................................
Skip missed dependencies in ResourcesTest::testUnsatisfiableDependencies
When a dependency is missing the test
ResourcesTest::testUnsatisfiableDependencies gives a error because of
Undefined index and stops further checks. Skip this situation because
the existing test ResourcesTest::testMissingDependencies already gives a
failure with a better explanation in this situation.
Change-Id: I71a88551df67d52ea96bf7283b5de892692f9336
---
M tests/phpunit/structure/ResourcesTest.php
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/structure/ResourcesTest.php
b/tests/phpunit/structure/ResourcesTest.php
index 2396ea2..16a9f3a 100644
--- a/tests/phpunit/structure/ResourcesTest.php
+++ b/tests/phpunit/structure/ResourcesTest.php
@@ -91,6 +91,10 @@
foreach ( $data['modules'] as $moduleName => $module ) {
$moduleTargets = $module->getTargets();
foreach ( $module->getDependencies() as $dep ) {
+ if ( !isset( $data['modules'][$dep] ) ) {
+ // Missing dependencies reported by
testMissingDependencies
+ continue;
+ }
$targets = $data['modules'][$dep]->getTargets();
foreach ( $moduleTargets as $moduleTarget ) {
$this->assertContains(
--
To view, visit https://gerrit.wikimedia.org/r/190649
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71a88551df67d52ea96bf7283b5de892692f9336
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
