Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/192256
Change subject: Emit trace.init.{enter,exit} events
......................................................................
Emit trace.init.{enter,exit} events
Having the entire initialization process wrapped with trace enter/exit events
makes it possible for vbench to have a generic means of specifying which unit
of work it wants to measure. This is a follow-up for Ife5664e87.
Task: T89536
Change-Id: I236f09be0bb00bcc206ddc4062c5b5d8e2509004
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/56/192256/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
index 7367500..f37a83d 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
@@ -71,6 +71,7 @@
return target.activate();
} )
.then( function () {
+ ve.track( 'trace.init.exit' );
ve.track( 'mwedit.ready' );
} )
.always( hideLoading );
@@ -363,6 +364,7 @@
return;
}
+ ve.track( 'trace.init.enter' );
ve.track( 'mwedit.init', { type: 'page', mechanism:
'click' } );
if ( history.pushState && uri.query.veaction !== 'edit'
) {
@@ -387,6 +389,7 @@
return;
}
+ ve.track( 'trace.init.enter' );
ve.track( 'mwedit.init', { type: 'section', mechanism:
'click' } );
if ( history.pushState && uri.query.veaction !== 'edit'
) {
@@ -487,6 +490,7 @@
if ( isViewPage && uri.query.veaction === 'edit' ) {
isSection = uri.query.vesection !== undefined;
+ ve.track( 'trace.init.enter' );
ve.track( 'mwedit.init', { type: isSection ?
'section' : 'page', mechanism: 'url' } );
activateTarget( getTarget() );
}
--
To view, visit https://gerrit.wikimedia.org/r/192256
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I236f09be0bb00bcc206ddc4062c5b5d8e2509004
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
