Robert Vogel has submitted this change and it was merged.
Change subject: NamespaceCombo: removed defaultValue
......................................................................
NamespaceCombo: removed defaultValue
Apparently it is better to have no default value set.
THIS CHANGE NEEDS TO BE CHERRYPICKED TO REL1_23 AND master!
Change-Id: If9996f7393efd7c1e32e3f82faeaa1b8d0dd77ee
---
M resources/bluespice.extjs/BS/form/NamespaceCombo.js
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Robert Vogel: Verified; Looks good to me, approved
diff --git a/resources/bluespice.extjs/BS/form/NamespaceCombo.js
b/resources/bluespice.extjs/BS/form/NamespaceCombo.js
index 85df785..d439171 100644
--- a/resources/bluespice.extjs/BS/form/NamespaceCombo.js
+++ b/resources/bluespice.extjs/BS/form/NamespaceCombo.js
@@ -6,7 +6,6 @@
queryMode: 'local',
typeAhead: true,
triggerAction: 'all',
- value: 0,
fieldLabel: mw.message('bs-extjs-namespace').plain(),
//Custom Settings
@@ -35,4 +34,4 @@
}
this.callParent([value, doSelect]);
}
-});
\ No newline at end of file
+});
--
To view, visit https://gerrit.wikimedia.org/r/191553
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9996f7393efd7c1e32e3f82faeaa1b8d0dd77ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation
Gerrit-Branch: REL1_22
Gerrit-Owner: Robert Vogel <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: Pigpen <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
