Pwirth has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/192321

Change subject: Added Messages to number filter range menu
......................................................................

Added Messages to number filter range menu

* Added i18n messages
* Added Fieldlabels to Ext.ux.grid.menu.RangeMenu
* Added i18n keys to resource module messages array
=> Needs merge to REL1_23 and master

Change-Id: Ibf0571e3ad35b6086fa89d64b5cb61ed4fd72a06
---
M languages/BlueSpice.ExtJS.i18n.php
M resources/Resources.php
M resources/bluespice.extjs/Ext.ux/grid/menu/RangeMenu.js
3 files changed, 16 insertions(+), 8 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceFoundation 
refs/changes/21/192321/1

diff --git a/languages/BlueSpice.ExtJS.i18n.php 
b/languages/BlueSpice.ExtJS.i18n.php
index 71836b8..c8d2782 100644
--- a/languages/BlueSpice.ExtJS.i18n.php
+++ b/languages/BlueSpice.ExtJS.i18n.php
@@ -38,7 +38,9 @@
        'bs-extjs-filter-contains' => 'Contains',
        'bs-extjs-filter-contains-not' => 'Contains not',
        'bs-extjs-filter-starts-with' => 'Starts with',
-       'bs-extjs-filter-ends-with' => 'Ends with'
+       'bs-extjs-filter-ends-with' => 'Ends with',
+       'bs-extjs-filter-greater-than' => 'Greater than',
+       'bs-extjs-filter-less-than' => 'Less than',
 );
 
 $messages['qqq'] = array(
@@ -76,7 +78,9 @@
        'bs-extjs-filter-contains' => 'Label for a filter input box that 
fitlers for datasets where the value of the field contains the entered value',
        'bs-extjs-filter-contains-not' => 'Label for a filter input box that 
fitlers for datasets where the value of the field does not contain the entered 
value',
        'bs-extjs-filter-starts-with' => 'Label for a filter input box that 
fitlers for datasets where the value of the field starts with the entered 
value',
-       'bs-extjs-filter-ends-with' => 'Label for a filter input box that 
fitlers for datasets where the value of the field ends with the entered value'
+       'bs-extjs-filter-ends-with' => 'Label for a filter input box that 
fitlers for datasets where the value of the field ends with the entered value',
+       'bs-extjs-filter-greater-than' => 'Label for a filter input box that 
fitlers for datasets where the value of the field is greater than the entered 
value',
+       'bs-extjs-filter-less-than' => 'Label for a filter input box that 
fitlers for datasets where the value of the field is less than the entered 
value',
 );
 
 $messages['de'] = array(
@@ -115,7 +119,9 @@
        'bs-extjs-filter-contains' => 'Enthält',
        'bs-extjs-filter-contains-not' => 'Enthält nicht',
        'bs-extjs-filter-starts-with' => 'Beginnt mit',
-       'bs-extjs-filter-ends-with' => 'Endet mit'
+       'bs-extjs-filter-ends-with' => 'Endet mit',
+       'bs-extjs-filter-greater-than' => 'Größer als',
+       'bs-extjs-filter-less-than' => 'Kleiner als',
 );
 
 $messages['de-formal'] = array(
diff --git a/resources/Resources.php b/resources/Resources.php
index a799ea4..65d63d5 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -106,7 +106,9 @@
                'bs-extjs-filter-contains',
                'bs-extjs-filter-contains-not',
                'bs-extjs-filter-starts-with',
-               'bs-extjs-filter-ends-with'
+               'bs-extjs-filter-ends-with',
+               'bs-extjs-filter-greater-than',
+               'bs-extjs-filter-less-than',
        ),
        'position' => 'bottom'
 ) + $aResourceModuleTemplate;
diff --git a/resources/bluespice.extjs/Ext.ux/grid/menu/RangeMenu.js 
b/resources/bluespice.extjs/Ext.ux/grid/menu/RangeMenu.js
index 1ae1b6b..c6a1015 100644
--- a/resources/bluespice.extjs/Ext.ux/grid/menu/RangeMenu.js
+++ b/resources/bluespice.extjs/Ext.ux/grid/menu/RangeMenu.js
@@ -73,9 +73,9 @@
 }</pre>
      */
     fieldLabels: {
-        gt: 'Greater Than',
-        lt: 'Less Than',
-        eq: 'Equal To'
+        gt: mw.messages.get('bs-extjs-filter-greater-than'),
+        lt: mw.messages.get('bs-extjs-filter-less-than'),
+        eq: mw.messages.get('bs-extjs-filter-equals')
     },
 
     /**
@@ -90,7 +90,6 @@
      * </pre>
      */
     menuItemCfgs : {
-        emptyText: 'Enter Number...',
         selectOnFocus: false,
         width: 155
     },
@@ -137,6 +136,7 @@
                     labelCls: 'ux-rangemenu-icon ' + me.itemIconCls[item],
                     labelSeparator: '',
                     labelWidth: 29,
+                    emptyText: me.fieldLabels[item],
                     listeners: {
                         scope: me,
                         change: me.onInputChange,

-- 
To view, visit https://gerrit.wikimedia.org/r/192321
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf0571e3ad35b6086fa89d64b5cb61ed4fd72a06
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation
Gerrit-Branch: REL1_22
Gerrit-Owner: Pwirth <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to