jenkins-bot has submitted this change and it was merged. Change subject: QA: rubocop fixes broke the tests in the builds ......................................................................
QA: rubocop fixes broke the tests in the builds regenerated rubocop config so those checks also stay green Change-Id: Ib8a88c88c02d1638e758d62eb86f2ac59feefe5d --- M .rubocop.yml M .rubocop_todo.yml M tests/browser/features/step_definitions/notifications_steps.rb 3 files changed, 7 insertions(+), 11 deletions(-) Approvals: Cmcmahon: Looks good to me, approved jenkins-bot: Verified diff --git a/.rubocop.yml b/.rubocop.yml index 6ca0170..7ce21af 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -9,9 +9,6 @@ Metrics/CyclomaticComplexity: Enabled: false -Metrics/LineLength: - Max: 100 - Metrics/MethodLength: Enabled: false diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index cb8484e..0649914 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,13 +1,14 @@ # This configuration was generated by `rubocop --auto-gen-config` -# on 2015-02-20 09:41:11 -0700 using RuboCop version 0.29.0. +# on 2015-02-23 09:43:04 -0700 using RuboCop version 0.29.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 3 -Style/AccessorMethodName: - Enabled: false +# Offense count: 2 +# Configuration parameters: AllowURI, URISchemes. +Metrics/LineLength: + Max: 113 # Offense count: 1 # Configuration parameters: AllowedVariables. diff --git a/tests/browser/features/step_definitions/notifications_steps.rb b/tests/browser/features/step_definitions/notifications_steps.rb index 1a6d30b..37843a8 100644 --- a/tests/browser/features/step_definitions/notifications_steps.rb +++ b/tests/browser/features/step_definitions/notifications_steps.rb @@ -83,11 +83,9 @@ end Then(/^I have no new notifications$/) do - expect(on(ArticlePage).flyout_link_element.when_present.class_name).not_to - match 'mw-echo-unread-notifications' + expect(on(ArticlePage).flyout_link_element.when_present.class_name).not_to match 'mw-echo-unread-notifications' end Then(/^I have new notifications$/) do - expect(on(ArticlePage).flyout_link_element.when_present.class_name).to - match 'mw-echo-unread-notifications' + expect(on(ArticlePage).flyout_link_element.when_present.class_name).to match 'mw-echo-unread-notifications' end -- To view, visit https://gerrit.wikimedia.org/r/192329 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8a88c88c02d1638e758d62eb86f2ac59feefe5d Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Cmcmahon <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: Dduvall <[email protected]> Gerrit-Reviewer: Zfilipin <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
