Dduvall has uploaded a new change for review.
https://gerrit.wikimedia.org/r/192357
Change subject: Corrected Style/RedundantSelf RuboCop offenses
......................................................................
Corrected Style/RedundantSelf RuboCop offenses
Change-Id: Ie9dd695cad2af21a7f8f2fb1fe76ae0810960786
---
M .rubocop_todo.yml
M lib/mediawiki_selenium/support/pages/login_page.rb
2 files changed, 2 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium
refs/changes/57/192357/1
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index a8cb048..9393c64 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -5,11 +5,6 @@
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/RedundantSelf:
- Enabled: false
-
# Offense count: 1
# Cop supports --auto-correct.
Style/SpecialGlobalVars:
diff --git a/lib/mediawiki_selenium/support/pages/login_page.rb
b/lib/mediawiki_selenium/support/pages/login_page.rb
index b070ecb..2d3d39a 100644
--- a/lib/mediawiki_selenium/support/pages/login_page.rb
+++ b/lib/mediawiki_selenium/support/pages/login_page.rb
@@ -19,8 +19,8 @@
end
def login_with(username, password, wait_for_logout_element = true)
- self.username_element.when_present.send_keys(username)
- self.password_element.when_present.send_keys(password)
+ username_element.when_present.send_keys(username)
+ password_element.when_present.send_keys(password)
login_element.when_present.click
logout_element.when_present(10) if wait_for_logout_element
end
--
To view, visit https://gerrit.wikimedia.org/r/192357
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9dd695cad2af21a7f8f2fb1fe76ae0810960786
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Dduvall <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
