[MediaWiki-commits] [Gerrit] Corrected Style/TrailingComma RuboCop offenses - change (mediawiki/selenium)

[Dduvall (Code Review)]

Dduvall has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/192359

Change subject: Corrected Style/TrailingComma RuboCop offenses
......................................................................

Corrected Style/TrailingComma RuboCop offenses

Change-Id: I95aef92162b9e527729acf61a75d10de50e65838
---
M .rubocop_todo.yml
M lib/mediawiki_selenium/remote_browser_factory.rb
M spec/environment_spec.rb
3 files changed, 6 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium 
refs/changes/59/192359/1

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index d0c4906..65811e0 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -11,12 +11,6 @@
 Style/StringLiterals:
   Enabled: false
 
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
-Style/TrailingComma:
-  Enabled: false
-
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, 
Whitelist.
diff --git a/lib/mediawiki_selenium/remote_browser_factory.rb 
b/lib/mediawiki_selenium/remote_browser_factory.rb
index f448c3c..b006745 100644
--- a/lib/mediawiki_selenium/remote_browser_factory.rb
+++ b/lib/mediawiki_selenium/remote_browser_factory.rb
@@ -57,7 +57,7 @@
           payload: {
             public: true,
             passed: status == :passed,
-            build: env.lookup(:build_number, default: nil),
+            build: env.lookup(:build_number, default: nil)
           }.to_json
         )
 
diff --git a/spec/environment_spec.rb b/spec/environment_spec.rb
index 195af74..0b67e26 100644
--- a/spec/environment_spec.rb
+++ b/spec/environment_spec.rb
@@ -13,7 +13,7 @@
         mediawiki_api_url: mediawiki_api_url,
         mediawiki_url: mediawiki_url,
         mediawiki_user: mediawiki_user,
-        mediawiki_password: mediawiki_password,
+        mediawiki_password: mediawiki_password
       }
     end
 
@@ -98,7 +98,7 @@
             mediawiki_user: "user",
             mediawiki_password: "pass",
             mediawiki_user_b: "user b",
-            mediawiki_password_b: "pass b",
+            mediawiki_password_b: "pass b"
           }
         end
 
@@ -117,7 +117,7 @@
           {
             mediawiki_user: "user",
             mediawiki_password: "pass",
-            mediawiki_user_b: "user b",
+            mediawiki_user_b: "user b"
           }
         end
 
@@ -319,7 +319,7 @@
         {
           mediawiki_url: "http://an.example/wiki";,
           mediawiki_url_b: "http://altb.example/wiki";,
-          mediawiki_url_c: "http://altc.example/wiki";,
+          mediawiki_url_c: "http://altc.example/wiki";
         }
       end
 
@@ -429,7 +429,7 @@
           mediawiki_url: "http://a.example/wiki";,
           mediawiki_url_b: "http://b.example/wiki";,
           mediawiki_api_url: "http://a.example/api";,
-          mediawiki_api_url_b: "http://b.example/api";,
+          mediawiki_api_url_b: "http://b.example/api";
         }
       end
 

-- 
To view, visit https://gerrit.wikimedia.org/r/192359
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I95aef92162b9e527729acf61a75d10de50e65838
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Dduvall <dduv...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits