EBernhardson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/192472
Change subject: Skip test if NS_MAIN isnt a capitalized namespace
......................................................................
Skip test if NS_MAIN isnt a capitalized namespace
This test is seeing if creating a reference to both 'foo'
and 'Foo' are treated the same, but that is only valid when
NS_MAIN actually capitalizes, otherwise they are correctly
considered different pages.
Change-Id: I55e3746a710acab0d062ccc20d06ac5da9492cdd
---
M tests/phpunit/LinksTableTest.php
1 file changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/72/192472/1
diff --git a/tests/phpunit/LinksTableTest.php b/tests/phpunit/LinksTableTest.php
index e2cd5a0..daf2525 100644
--- a/tests/phpunit/LinksTableTest.php
+++ b/tests/phpunit/LinksTableTest.php
@@ -265,12 +265,13 @@
$references['fooLink'],
),
array(
- $references['fooLink2'],
+ $references['FooLink'],
),
array(
),
array(
),
+ \MWNamespace::isCapitalized( NS_MAIN ) ? false
: 'NS_MAIN must be capitalized for test to work',
),
// Inequality robustness
array(
@@ -293,7 +294,11 @@
/**
* @dataProvider provideReferenceDiff
*/
- public function testReferenceDiff( $old, $new, $expectedAdded,
$expectedRemoved ) {
+ public function testReferenceDiff( $old, $new, $expectedAdded,
$expectedRemoved, $skip = false ) {
+ if ( $skip !== false ) {
+ $this->markTestSkipped( $skip );
+ return;
+ }
list( $workflow, $revision, $title ) =
$this->getBlandTestObjects();
foreach( array( 'old', 'new', 'expectedAdded',
'expectedRemoved' ) as $varName ) {
@@ -414,7 +419,7 @@
'refType' => 'link',
'value' => '/Subpage',
),
- 'fooLink2' => array(
+ 'FooLink' => array(
'factoryMethod' => 'createWikiReference',
'refType' => 'link',
'value' => 'foo',
--
To view, visit https://gerrit.wikimedia.org/r/192472
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55e3746a710acab0d062ccc20d06ac5da9492cdd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
