jenkins-bot has submitted this change and it was merged.
Change subject: RadioOptionWidget: Make disabling single options work
......................................................................
RadioOptionWidget: Make disabling single options work
Change-Id: I177ae414f5dbf96b1ea2edc365a1689ae78f54e2
---
M demos/pages/widgets.js
M src/widgets/RadioOptionWidget.js
2 files changed, 22 insertions(+), 3 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/demos/pages/widgets.js b/demos/pages/widgets.js
index e7eea80..b2b8095 100644
--- a/demos/pages/widgets.js
+++ b/demos/pages/widgets.js
@@ -676,6 +676,11 @@
new
OO.ui.RadioOptionWidget( {
data: 'Dog',
label: 'Dog'
+ } ),
+ new
OO.ui.RadioOptionWidget( {
+ data:
'Goldfish',
+ label:
'Goldfish',
+ disabled: true
} )
]
} ),
diff --git a/src/widgets/RadioOptionWidget.js b/src/widgets/RadioOptionWidget.js
index e01c669..3663e8f 100644
--- a/src/widgets/RadioOptionWidget.js
+++ b/src/widgets/RadioOptionWidget.js
@@ -10,11 +10,14 @@
* @param {Object} [config] Configuration options
*/
OO.ui.RadioOptionWidget = function OoUiRadioOptionWidget( config ) {
+ // Configuration initialization
+ config = config || {};
+
+ // Properties (must be done before parent constructor which calls
#setDisabled)
+ this.radio = new OO.ui.RadioInputWidget( { value: config.data,
tabIndex: -1 } );
+
// Parent constructor
OO.ui.RadioOptionWidget.super.call( this, config );
-
- // Properties
- this.radio = new OO.ui.RadioInputWidget( { value: config.data,
tabIndex: -1 } );
// Initialization
this.$element
@@ -48,3 +51,14 @@
return this;
};
+
+/**
+ * @inheritdoc
+ */
+OO.ui.RadioOptionWidget.prototype.setDisabled = function ( disabled ) {
+ OO.ui.RadioOptionWidget.super.prototype.setDisabled.call( this,
disabled );
+
+ this.radio.setDisabled( this.isDisabled() );
+
+ return this;
+};
--
To view, visit https://gerrit.wikimedia.org/r/192092
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I177ae414f5dbf96b1ea2edc365a1689ae78f54e2
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
