Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/192716

Change subject: Flush any implicit transactions in RecentChangesUpdateJob
......................................................................

Flush any implicit transactions in RecentChangesUpdateJob

Bug: T89806
Change-Id: Ibd71966225de3dfb392002fc3fd181b2ff521b9d
(cherry picked from commit 2c788bddc08b0211982407bdc47b137b60111871)
---
M includes/jobqueue/jobs/RecentChangesUpdateJob.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/16/192716/1

diff --git a/includes/jobqueue/jobs/RecentChangesUpdateJob.php 
b/includes/jobqueue/jobs/RecentChangesUpdateJob.php
index 236b4d4..b54ecfd 100644
--- a/includes/jobqueue/jobs/RecentChangesUpdateJob.php
+++ b/includes/jobqueue/jobs/RecentChangesUpdateJob.php
@@ -76,6 +76,8 @@
                        if ( $rcIds ) {
                                $dbw->delete( 'recentchanges', array( 'rc_id' 
=> $rcIds ), __METHOD__ );
                        }
+                       // No need for this to be in a transaction.
+                       $dbw->commit( __METHOD__, 'flush' );
                } while ( $rcIds );
 
                $dbw->unlock( $lockKey, __METHOD__ );

-- 
To view, visit https://gerrit.wikimedia.org/r/192716
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd71966225de3dfb392002fc3fd181b2ff521b9d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.25wmf17
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to