Amire80 has uploaded a new change for review. https://gerrit.wikimedia.org/r/192731
Change subject: [BrowserTest] Fix VisualEditor_More_Settings scenario ...................................................................... [BrowserTest] Fix VisualEditor_More_Settings scenario The screenshot here is supposed to capture the menu that opens when the hamburger icon is pressed. The previous code captured the whole toolbar. This is now fixed. A sample screenshot is here: https://commons.wikimedia.org/wiki/File:VisualEditor_More_Settings-en.png Change-Id: Id9501b8b1b8d41411c2f81bf4d4954a6bb41addc --- M modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb 2 files changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/31/192731/1 diff --git a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb index 377185c..dbff462 100644 --- a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb +++ b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb @@ -155,14 +155,10 @@ Then(/^I should see pull-down menu containing Page Settings$/) do on(VisualEditorPage).page_settings_element.when_present.should be_visible - step 'I take screenshot of Visual Editor insert menu' -end - -Then(/^I take screenshot of Visual Editor insert menu$/) do Screenshot.capture( @browser, "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", - [@current_page.tools_menu_element, @current_page.page_option_menu_element] + [@current_page.disabled_save_button_element, @current_page.page_option_menu_element] ) end diff --git a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb index dd92673..76b6797 100644 --- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb +++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb @@ -115,7 +115,7 @@ checkbox(:option_to_refer_as_disambiguation_page, index: 3) span(:option_to_set_index_by_search, class: 'oo-ui-labelElement-label', text: 'Yes', index: 0) span(:option_to_show_new_section_tab, class: 'oo-ui-labelElement-label', text: 'Yes', index: 1) - div(:page_option_menu, class: 'oo-ui-toolGroup-tools oo-ui-clippableElement-clippable', index: 6) + div(:page_option_menu, css: '.oo-ui-toolbar-actions .oo-ui-toolbar-tools .oo-ui-toolGroup-tools.oo-ui-clippableElement-clippable') span(:page_settings, class: 'oo-ui-iconElement-icon oo-ui-icon-settings') div(:page_settings_editlinks, class: 've-test-page-settings-noeditsection') div(:page_text, id: 'mw-content-text') -- To view, visit https://gerrit.wikimedia.org/r/192731 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id9501b8b1b8d41411c2f81bf4d4954a6bb41addc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Amire80 <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
