jenkins-bot has submitted this change and it was merged.
Change subject: fix parameter ordering
......................................................................
fix parameter ordering
the new parameter as $10
fixes I9ee51db221aeaf149eca6aec46d2c7258def9915
Change-Id: Icd90fd97af301931754ab0359d9ba2feb2456db1
---
M SpecialNotifyTranslators.php
M i18n/en.json
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
Southparkfan: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/SpecialNotifyTranslators.php b/SpecialNotifyTranslators.php
index f5f0160..db29086 100644
--- a/SpecialNotifyTranslators.php
+++ b/SpecialNotifyTranslators.php
@@ -638,9 +638,9 @@
$this->getTranslationURLs( $relevantLanguages,
'talkpage', $userFirstLanguage ),
$this->getPriorityClause( $userFirstLanguage ),
$this->getDeadlineClause( $userFirstLanguage ),
- $notificationText,
- $this->getSignupURL()
- )->numParams( count( $relevantLanguages ) )
+ $notificationText
+ )->numParams( count( $relevantLanguages ) ) // $9
+ ->params( $this->getSignupURL() ) // $10
->inLanguage( $userFirstLanguage )
->text();
// Bidi-isolation of site name from date
diff --git a/i18n/en.json b/i18n/en.json
index aedd353..51ff28d 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -47,7 +47,7 @@
"translationnotifications-error-no-translatable-pages": "There are no
translatable pages in this wiki.",
"translationnotifications-email-subject": "Please translate the page $1",
"translationnotifications-email-body": "Hello $1,\n\nYou are receiving
this email because you {{GENDER:$10|signed up}} as a translator
{{PLURAL:$9|to}} $2 on {{SITENAME}}.\n\nThere is a page to translate there:
$3.\nYou can translate it by clicking the following
link:\n$4\n\n$5\n$6\n\n$7\n\nYour help is greatly appreciated. Translators like
you help {{SITENAME}} to function\nas a truly multilingual community.\n\nThank
you!\n{{SITENAME}} translation coordinators\n\n----\n\nYou are receiving this
email because you signed up to receive emails related to translations on
{{SITENAME}}. To unsubscribe or to change your notification preferences for
translations, please visit $8.",
- "translationnotifications-talkpage-body": "Hello $2,\n\nYou are receiving
this notification because you {{GENDER:$1|signed up}} as a translator
{{PLURAL:$9|to}} $3 on {{SITENAME}}.\nThe page [[$4]] is available for
translation. You can translate it here:\n$5\n\n$6\n$7\n\n$8\n\nYour help is
greatly appreciated. Translators like you help {{SITENAME}} to function\nas a
truly multilingual community.\n\nYou can change your notification preferences
[$9 here].\n\nThank you!\n\n{{SITENAME}} translation coordinators",
+ "translationnotifications-talkpage-body": "Hello $2,\n\nYou are receiving
this notification because you {{GENDER:$1|signed up}} as a translator
{{PLURAL:$9|to}} $3 on {{SITENAME}}.\nThe page [[$4]] is available for
translation. You can translate it here:\n$5\n\n$6\n$7\n\n$8\n\nYour help is
greatly appreciated. Translators like you help {{SITENAME}} to function\nas a
truly multilingual community.\n\nYou can change your notification preferences
[$10 here].\n\nThank you!\n\n{{SITENAME}} translation coordinators",
"translationnotifications-notification-url-listitem": "translate to $1",
"translationnotifications-digestemail-subject": "Digest email for
translation requests from {{SITENAME}}",
"translationnotifications-digestemail-body": "Hello $1,\n\nYou are
receiving this email because you {{GENDER:$1|signed up}} as a translator to $2
on {{SITENAME}}.\n\nThere {{PLURAL:$3|is 1 page|are $3 pages}} available for
translation. The details are given below.\n\n$4\n\nYour help is greatly
appreciated. Translators like you help {{SITENAME}} to function\nas a truly
multilingual community.\n\nThank you!\n{{SITENAME}} translation
administrators\n\n----\n\nYou are receiving this email because you signed up to
receive emails related to translations on {{SITENAME}}. To unsubscribe or to
change your notification preferences for translations, please visit <$5>.",
--
To view, visit https://gerrit.wikimedia.org/r/192797
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd90fd97af301931754ab0359d9ba2feb2456db1
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/TranslationNotifications
Gerrit-Branch: master
Gerrit-Owner: Se4598 <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Nemo bis <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Southparkfan <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
