Aaron Schulz has submitted this change and it was merged.
Change subject: PostreSQL: DatabaseBase constructor cleanups
......................................................................
PostreSQL: DatabaseBase constructor cleanups
Change I29b79a3c1bb2b5e51c1c8f5e04cd08c71e0662a3 rendered
it uninstallable on PostgreSQL.
Make the corresponding API changes to PostgreSQL installer.
Bug: T90288
Change-Id: I2019893ad705d99f3dbbce13690cd808cfb71d4a
---
M includes/installer/PostgresInstaller.php
1 file changed, 7 insertions(+), 5 deletions(-)
Approvals:
Aaron Schulz: Verified; Looks good to me, approved
diff --git a/includes/installer/PostgresInstaller.php
b/includes/installer/PostgresInstaller.php
index e19f9aa..b18fe94 100644
--- a/includes/installer/PostgresInstaller.php
+++ b/includes/installer/PostgresInstaller.php
@@ -262,11 +262,13 @@
$status = Status::newGood();
foreach ( $dbs as $db ) {
try {
- $conn = new DatabasePostgres(
- $this->getVar( 'wgDBserver' ),
- $user,
- $password,
- $db );
+ $p = array(
+ 'host' => $this->getVar( 'wgDBserver' ),
+ 'user' => $user,
+ 'password' => $password,
+ 'dbname' => $db
+ );
+ $conn = DatabaseBase::factory( 'postgres', $p );
} catch ( DBConnectionError $error ) {
$conn = false;
$status->fatal( 'config-pg-test-error', $db,
--
To view, visit https://gerrit.wikimedia.org/r/192500
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2019893ad705d99f3dbbce13690cd808cfb71d4a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jjanes <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Waldir <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
