Mwjames has submitted this change and it was merged.

Change subject: Fixed a bunch of issues with feed printer
......................................................................


Fixed a bunch of issues with feed printer

* Improved docs
* Fixed indent
* Fixed incorrect ref to var name (fatal error)
* Added forewards compat for ContentHandler
* Fixed methods retruning void instead of string on error

Change-Id: I08e73188b3b941b98b3ab318a0ef36b634246c32
---
M includes/queryprinters/SMW_QP_Feed.php
1 file changed, 54 insertions(+), 31 deletions(-)

Approvals:
  Mwjames: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33117
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I08e73188b3b941b98b3ab318a0ef36b634246c32
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Daniel Werner <[email protected]>
Gerrit-Reviewer: Denny Vrandecic <[email protected]>
Gerrit-Reviewer: Foxtrott <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Kghbln <[email protected]>
Gerrit-Reviewer: Markus Kroetzsch <[email protected]>
Gerrit-Reviewer: Mwjames <[email protected]>
Gerrit-Reviewer: Nischayn22 <[email protected]>
Gerrit-Reviewer: Yaron Koren <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to