jenkins-bot has submitted this change and it was merged.

Change subject: Exclude null rows from Special:MediaStatistics
......................................................................


Exclude null rows from Special:MediaStatistics

The commons db has a random null row in the image table, adding
a non-sensical row to this report.

Bug: T74535
Change-Id: Ie290e588af56aee7d5303954202f7923b64d2272
---
M includes/specials/SpecialMediaStatistics.php
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Gilles: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specials/SpecialMediaStatistics.php 
b/includes/specials/SpecialMediaStatistics.php
index 1056cda..b62de5d 100644
--- a/includes/specials/SpecialMediaStatistics.php
+++ b/includes/specials/SpecialMediaStatistics.php
@@ -73,6 +73,10 @@
                                'namespace' => NS_MEDIA, /* needs to be 
something */
                                'value' => '1'
                        ),
+                       'conds' => array(
+                               // WMF has a random null row in the db
+                               'img_media_type IS NOT NULL'
+                       ),
                        'options' => array(
                                'GROUP BY' => array(
                                        'img_media_type',

-- 
To view, visit https://gerrit.wikimedia.org/r/192886
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie290e588af56aee7d5303954202f7923b64d2272
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff <[email protected]>
Gerrit-Reviewer: GergÅ‘ Tisza <[email protected]>
Gerrit-Reviewer: Gilles <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to